Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compose): Add pause and unpause commands #1477

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

LucaSeri
Copy link
Contributor

@LucaSeri LucaSeri commented Mar 30, 2024

Prerequisite checklist

  • Read the contribution guidelines regarding submitting new changes to the project;
  • Tested your changes against relevant architectures and platforms;
  • Ran make fmt on your commit series before opening this PR;
  • Updated relevant documentation.

Description of changes

The pause and unpause commands offer even better granularity over a compose project.
These commands allow users to suspend and resume projects without having to restart them completely.

Depends on: #1476

@LucaSeri LucaSeri requested a review from nderjung March 30, 2024 13:54
The pause subcommand pauses all the services in a project.

Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
The unpause subcommand resumes any paused services in a project.

Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
This is esentially a heuristic with which we can determine a reasonable
project status based on the project's services status. This also
makes expanding possible project statuses trivial.

Signed-off-by: Luca Seritan <luca.seritan@gmail.com>
Copy link
Member

@nderjung nderjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nderjung nderjung merged commit ef1c315 into unikraft:staging Apr 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants