feat: Package directory volumes when using OCI #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
Signed-off-by: Cezar Craciunoiu <cezar.craciunoiu@unikraft.io>
nderjung
reviewed
Jul 25, 2023
| Output string `local:"true" long:"output" short:"o" usage:"Save the package at the following output"` | ||
| Platform string `local:"true" long:"plat" short:"p" usage:"Filter the creation of the package by platform of known targets"` | ||
| Target string `local:"true" long:"target" short:"t" usage:"Package a particular known target"` | ||
| Volume []string `local:"true" long:"volume" short:"v" usage:"Path to volume to bundle within the package (passing a path will automatically generate a CPIO image)"` |
There was a problem hiding this comment.
Based on the implementation, there is no CPIO generation so the usage should be updated.
nderjung
reviewed
Jul 25, 2023
Comment on lines
+20
to
+21
| AnnotationKernelVolumePath = "org.unikraft.kernel.volume-%d.path" | ||
| AnnotationKernelVolumeMount = "org.unikraft.kernel.volume-%d.mount" |
There was a problem hiding this comment.
To be consistent with Unikraft's core:
- org.unikraft.kernel.volume-%d.path"
+ org.unikraft.volume.fs%d.path"
- org.unikraft.kernel.volume-%d.mount"
+ org.unikraft.volume.fs%d.mount"There was a problem hiding this comment.
Let's also add the type here:
org.unikraft.volume.fs%d.type
There was a problem hiding this comment.
I am thinking about the attributes that are coming from the new addition occuring in the core to handle volumes: unikraft/unikraft#979
nderjung
reviewed
Jul 25, 2023
| @@ -17,6 +17,8 @@ const ( | |||
| AnnotationKernelKConfig = "org.unikraft.kernel.kconfig." | |||
| AnnotationKernelArch = "org.unikraft.kernel.arch" | |||
| AnnotationKernelPlat = "org.unikraft.kernel.plat" | |||
| AnnotationKernelVolumePath = "org.unikraft.kernel.volume-%d.path" | |||
| AnnotationKernelVolumeMount = "org.unikraft.kernel.volume-%d.mount" | |||
| AnnotationFilesystemPath = "org.unikraft.filesystem" | |||
| AnnotationDiskIndexPathPattern = "org.unikraft.disk-%d" | |||
There was a problem hiding this comment.
I think this is what filesystem and disk- was meant to be. So these can be removed.
craciunoiuc
added
kind/enhancement
|
@nderjung is this still needed? I feel like there was no real push to have volumes in packages. Should I close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite checklist
make fmton your commit series before opening this PR;Description of changes