feat(logs): Refactor and expose log tailing logic

[LucaSeri]

Prerequisite checklist

• Read the contribution guidelines regarding submitting new changes to the project;
• Tested your changes against relevant architectures and platforms;
• Ran make fmt on your commit series before opening this PR;
• Updated relevant documentation.

Description of changes

This is currently based on #927.
This PR merges the two implementations of logs tailing from the logs and run modules and exposes the functionality through the logs module.
A fix was introduced such that kraft run doesn't attempt to shutdown the entirety of kraft as this results in very unpredictable and confusing behavior when using kraftkit as an API. Instead, just report the errors and let the caller handle them.

[nderjung]

Hi @LucaSeri, thanks a lot for this! This PR just needs a rebase, also a couple of suggestions:

diff --git a/internal/cli/kraft/logs/logs.go b/internal/cli/kraft/logs/logs.go
index 5496614..4ea1d04 100644
--- a/internal/cli/kraft/logs/logs.go
+++ b/internal/cli/kraft/logs/logs.go
@@ -11,7 +11,6 @@ import (
        "io"
        "os"
 
-       zip "api.zip"
        "github.com/spf13/cobra"
 
        machineapi "kraftkit.sh/api/machine/v1alpha1"
@@ -130,7 +129,7 @@ func (opts *LogOptions) Run(ctx context.Context, args []string) error {
 }
 
 // FollowLogs tracks the logs generated by a machine and prints them to the context out stream.
-func FollowLogs(ctx context.Context, machine *zip.Object[machineapi.MachineSpec, machineapi.MachineStatus], controller machineapi.MachineService) error {
+func FollowLogs(ctx context.Context, machine *machineapi.Machine, controller machineapi.MachineService) error {
        ctx, cancel := context.WithCancel(ctx)
 
        var exitErr error
@@ -139,8 +138,7 @@ func FollowLogs(ctx context.Context, machine *zip.Object[machineapi.MachineSpec,
                events, errs, err := controller.Watch(ctx, machine)
                if err != nil {
                        cancel()
-                       log.G(ctx).Errorf("could not listen for machine updates: %v", err)
-                       exitErr = err
+                       exitErr = fmt.Errorf("listening to machine events: %w", err)
                        return
                }
 
@@ -192,7 +190,6 @@ loop:
                        }
 
                case <-ctx.Done():
-                       log.G(ctx).Debugf("log following context cancelled")
                        break loop
                }
        }

[nderjung]

Awesome, thanks!

Reviewed-by: Alexander Jung alex@unikraft.io
Approved-by: Alexander Jung alex@unikraft.io