-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] missing prophet/catboost/lightgbm library should not prevent use of others models #1360
Conversation
…aries such as prophet, lightgbm and catboost. users with partial install should still be able to import the others model and use them.
Codecov ReportBase: 93.89% // Head: 93.86% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1360 +/- ##
==========================================
- Coverage 93.89% 93.86% -0.03%
==========================================
Files 78 78
Lines 8520 8511 -9
==========================================
- Hits 8000 7989 -11
- Misses 520 522 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
I am still getting this error with =0.23.1 `/opt/conda/envs/myenv/lib/python3.7/site-packages/darts/models/init.py in /opt/conda/envs/myenv/lib/python3.7/site-packages/darts/models/forecasting/auto_arima.py in ImportError: cannot import name 'FutureCovariatesLocalForecastingModel' from 'darts.models.forecasting.forecasting_model' (/opt/conda/envs/myenv/lib/python3.7/site-packages/darts/models/forecasting/forecasting_model.py)` |
Mmhh that's weird. |
hi, also getting the error with darts version 0.23.1: |
resolved by "from darts.models.forecasting.tft_model import TFTModel" and "pip install lightning" |
Fixes ##1272 and #1217.
Summary
Exception handling in
models/__init__.py
to display warning message when trying to import models depending on uninstalled external libraries. The logger will display a warning message, linking to the INSTALL.md file when relevant.Other Information
CatBoostRegressor
.