Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement map method for TimeSeries #163

Merged
merged 7 commits into from
Jul 23, 2020
Merged

Implement map method for TimeSeries #163

merged 7 commits into from
Jul 23, 2020

Commits on Jul 22, 2020

  1. Implement map method for TimeSeries 

    An implementation for map is added. It uses pandas' applymap method.
A jupyter notebook to show the tests conducted.

Resolves: #121
    @Lovkush-A
    Lovkush-A committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    7ab8921 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into map-method

    @Lovkush-A
    Lovkush-A authored Jul 22, 2020
    Configuration menu
    Copy the full SHA
    a014558 View commit details
    Browse the repository at this point in the history

  3. Remove test_map jupyter notebook

    @Lovkush-A
    Lovkush-A committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    83078e1 View commit details
    Browse the repository at this point in the history

  4. Add unit tests for and check within map method 

    Unit tests test_map.py added.
Included a small check, that the indices are in a valid range, in map method in TimeSeries class.
    @Lovkush-A
    Lovkush-A committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    eb91127 View commit details
    Browse the repository at this point in the history

  5. Make minor adjustments to map method 

    Following hrzn's advice, various minor adjustments were made:
* Correct various spacing/wording inconsistencies
* Move contents of test_map.py into test_timeseries.py
* Added sanity test case to tests for map
* Changed type hints to np.number
* Removed an unncessary call to self.pd_dataframe()
    @Lovkush-A
    Lovkush-A committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    04fd502 View commit details
    Browse the repository at this point in the history

  6. Replace self.pd_dataframe with self._pd in map method

    @Lovkush-A
    Lovkush-A committed Jul 22, 2020
    Configuration menu
    Copy the full SHA
    550b9ed View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2020

  1. Add ticks to map method docstring

    @Lovkush-A
    Lovkush-A committed Jul 23, 2020
    Configuration menu
    Copy the full SHA
    f1fef9e View commit details
    Browse the repository at this point in the history