feature/cumsum #1988
Merged
feature/cumsum #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eliotdoesprogramming
changed the title
Codecov ReportPatch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
📢 Thoughts on this report? Let us know!. |
dennisbader
requested changes
Sep 13, 2023
There was a problem hiding this comment.
Thanks a lot for this PR @Eliotdoesprogramming 🚀
I added some suggestions, mainly that I would opt for dropping support for n in cumsum.
After that we can merge :)
dennisbader
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Thanks @Eliotdoesprogramming for this PR, looks great now 🚀
I applied the requested changes as we want to release the new version soon.
|
np thanks for doing it! I get a bit busy during the week. Happy to contribute |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1981
Summary
adds the cumsum function to the Timeseries class. Implementation uses the xarray implementation of cumsum.
Additionally adds unit tests for the cumsum function when n=1 and n=2
let me know if this needs any more refinement, thanks!