Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/exp smooth constructor args #2059

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Fix/exp smooth constructor args #2059

merged 5 commits into from
Nov 8, 2023

Conversation

madtoinou
Copy link
Collaborator

Fixes #2024.

Summary

  • Add kwargs argument to ExponentialSmoothing to expose all the parameters of the statsmodels model implementation
  • Kept the fit_kwargs argument unchanged to preserve the API
  • Slightly refactored the tests and added cases for the two kinds of kwargs

@madtoinou madtoinou changed the title Fix/exp smooth construtor args Fix/exp smooth constructor args Nov 7, 2023
Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @madtoinou

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
darts/models/forecasting/exponential_smoothing.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@dennisbader dennisbader merged commit da049e5 into master Nov 8, 2023
9 checks passed
@madtoinou madtoinou deleted the fix/exp_smooth_args branch December 11, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Option to pass "smoothing_level" to ES model
3 participants