-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/improve timeseries #2196
Feat/improve timeseries #2196
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2196 +/- ##
==========================================
- Coverage 93.92% 93.87% -0.06%
==========================================
Files 135 135
Lines 13394 13411 +17
==========================================
+ Hits 12580 12589 +9
- Misses 814 822 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we should maybe open a separate PR to refactor a bit the tests and leverage pytest.mark.parametrize
as we did for other tests.
this is a good idea... sorry if I was pity about that but having good tests is a must :-) |
Thanks @VascoSch92 and @madtoinou for the reviews. I applied the suggestion. For the tests I separated exceptions from behavior. Regarding parametrization we can make in a separate PR as @madtoinou suggested. We recently migrated from unittest to pytest which is why there are still some relics of un-parametrized tests around. |
Summary
Refactor time series constructor and methods for performance boosts
from_group_dataframe()
to perform some operations on the full DataFrame instead of every group iterationsgroup_cols
from being added to static covariates when usingTimeSeries.from_group_dataframe()
with parameterdrop_group_cols
. (addresses [INFO] Fit multiple time series usingRegressionModels
withstatic
andpast
covariates. #2183)Results
Boosts for "special" frequencies (e.g. "W-MON"): Series creation time boost by method and series length
Boosts for "normal" frequencies (e.g. "D"): Series creation time boost by method and series length
And here the actual time series creation times for all experiments
results_TimeSeries_D.csv
results_TimeSeries_W-MON.csv
results_TimeSeriesOld_D.csv
results_TimeSeriesOld_W-MON.csv