-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update hierarchy for single transform window_transform #2207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for giving this a go @madtoinou 🚀
It seems like the issue has not yet been fully fixed with these changed (i tried running the code snippet from the issue).
I left some comments/suggestions
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2207 +/- ##
=======================================
Coverage 93.88% 93.88%
=======================================
Files 135 135
Lines 13434 13451 +17
=======================================
+ Hits 12613 12629 +16
- Misses 821 822 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @madtoinou :) some last few suggestions, then it's ready.
Fixes #2204, fixes #2209.
Summary
window_transform()
is called with only one transform on all the components of the series, update the hierarchy with the new components names, otherwise, it's dropped.