Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update hierarchy for single transform window_transform #2207

Merged
merged 20 commits into from
Feb 24, 2024

Conversation

madtoinou
Copy link
Collaborator

@madtoinou madtoinou commented Feb 5, 2024

Fixes #2204, fixes #2209.

Summary

  • If window_transform() is called with only one transform on all the components of the series, update the hierarchy with the new components names, otherwise, it's dropped.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving this a go @madtoinou 🚀
It seems like the issue has not yet been fully fixed with these changed (i tried running the code snippet from the issue).

I left some comments/suggestions

darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4600453) 93.88% compared to head (84c82f7) 93.88%.

Files Patch % Lines
darts/timeseries.py 96.87% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2207   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files         135      135           
  Lines       13434    13451   +17     
=======================================
+ Hits        12613    12629   +16     
- Misses        821      822    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @madtoinou :) some last few suggestions, then it's ready.

CHANGELOG.md Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
darts/timeseries.py Show resolved Hide resolved
darts/timeseries.py Outdated Show resolved Hide resolved
@dennisbader dennisbader merged commit 24ae0e1 into master Feb 24, 2024
7 of 9 checks passed
@dennisbader dennisbader deleted the fix/hierarchy_window_transform branch February 24, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

‎TimeSeries.resample() Wrong method name in docs. [BUG] window_transform on TimeSeries with hierarchy
4 participants