Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use pre-commit also locally #2327

Merged
merged 5 commits into from
Apr 18, 2024
Merged

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Apr 15, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Addresses #2323 (comment)

Summary

use pre-commit also locally instead of calling separate tools

Other Information

Borda added a commit to Lightning-Sandbox/darts that referenced this pull request Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (8f8b514) to head (c0f76d9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2327   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files         138      138           
  Lines       14187    14187           
=======================================
  Hits        13338    13338           
  Misses        849      849           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@madtoinou madtoinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Borda for creating a separate PR for this, using pre-commit as a command for linting/formatting looks very neat.

Copy link
Collaborator

@dennisbader dennisbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @Borda, thanks for this contribution 🚀

Could you add an entry to CHANGELOG.md under this section (for the other PRs as well)?

Then we're ready to merge!

@Borda
Copy link
Contributor Author

Borda commented Apr 15, 2024

Could you add an entry to CHANGELOG.md under this section (for the other PRs as well)?

added 53256bc

@madtoinou @dennisbader so ready to land? 🦩

@dennisbader
Copy link
Collaborator

Hi @Borda, there are merge conflicts from the CHANGELOG.md. I could fix these myself for all the PRs however, it seems I don't have write permission to the forked repo.
Would it be possible to grant me access (I'd also like to slightly adapt the content for the changes in CHANGELOG)?
If not, you can also fix the conflicts, we merge all PRs and I'll update the content later.

@Borda
Copy link
Contributor Author

Borda commented Apr 16, 2024

Would it be possible to grant me access (I'd also like to slightly adapt the content for the changes in CHANGELOG)?

I di not do any restrictions, so all maintainers shall be able to push

dennisbader pushed a commit that referenced this pull request Apr 17, 2024
* lint: switch `flake8` to Ruff

* fixing issues

* build gradle

* noqa: E721

* revert changes of #2327

* ruff

* Apply suggestions from code review

* chlog
@dennisbader
Copy link
Collaborator

@Borda, the other PR was merged. If you merge the master into this one and move the changelog entry to the unreleased section, we're good to go.

@Borda
Copy link
Contributor Author

Borda commented Apr 17, 2024

@dennisbader ready

@dennisbader dennisbader merged commit aa761b0 into unit8co:master Apr 18, 2024
9 checks passed
@Borda Borda deleted the ci/lint branch April 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants