-
Notifications
You must be signed in to change notification settings - Fork 880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: use pre-commit
also locally
#2327
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2327 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 138 138
Lines 14187 14187
=======================================
Hits 13338 13338
Misses 849 849 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Borda for creating a separate PR for this, using pre-commit as a command for linting/formatting looks very neat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @Borda, thanks for this contribution 🚀
Could you add an entry to CHANGELOG.md
under this section (for the other PRs as well)?
Then we're ready to merge!
added 53256bc @madtoinou @dennisbader so ready to land? 🦩 |
Hi @Borda, there are merge conflicts from the |
I di not do any restrictions, so all maintainers shall be able to push |
@Borda, the other PR was merged. If you merge the master into this one and move the changelog entry to the unreleased section, we're good to go. |
@dennisbader ready |
Checklist before merging this PR:
Addresses #2323 (comment)
Summary
use pre-commit also locally instead of calling separate tools
Other Information