Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix index generation and n steps between #2357

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Apr 29, 2024

Checklist before merging this PR:

  • Mentioned all issues that this PR fixes or addresses.
  • Summarized the updates of this PR under Summary.
  • Added an entry under Unreleased in the Changelog.

Fixes #2352.

Summary

  • fixes a bug where n_steps_between did not work properly with custom business frequencies
  • fixes a bug where generate_index() with a negative frequencies and either start or end not intersecting with the frequency, did not return the correct index.
  • fixes other edge cases with generate_index() and n_steps_between

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 97.14286% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.02%. Comparing base (ca6a630) to head (9a1beeb).
Report is 1 commits behind head on master.

❗ Current head 9a1beeb differs from pull request most recent head 93d2b9a. Consider uploading reports for the commit 93d2b9a to get more accurate results

Files Patch % Lines
darts/utils/utils.py 97.05% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
+ Coverage   94.00%   94.02%   +0.02%     
==========================================
  Files         138      138              
  Lines       14201    14216      +15     
==========================================
+ Hits        13350    13367      +17     
+ Misses        851      849       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dennisbader dennisbader merged commit 62122be into master Apr 30, 2024
9 checks passed
@dennisbader dennisbader deleted the fix/n_steps_between_custom_freq branch April 30, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ValueError in metric calculation at series intersect slicing with custom frequency
2 participants