Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed wrong future covariates slicing with RangeIndex #858

Merged
merged 1 commit into from
Mar 19, 2022

Conversation

dennisbader
Copy link
Collaborator

Fixes #843

Summary

  • fixed wrong RangeIndex-based future covariates slicing for DualCovariatesForecastingModels
  • added range index tests for LocalForecastingModels

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2022

Codecov Report

Merging #858 (2ad425d) into master (0233756) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #858      +/-   ##
==========================================
+ Coverage   91.37%   91.40%   +0.02%     
==========================================
  Files          70       70              
  Lines        7105     7106       +1     
==========================================
+ Hits         6492     6495       +3     
+ Misses        613      611       -2     
Impacted Files Coverage Δ
darts/models/forecasting/forecasting_model.py 96.78% <100.00%> (+0.01%) ⬆️
darts/models/forecasting/prophet_model.py 94.24% <0.00%> (+0.71%) ⬆️
darts/models/forecasting/auto_arima.py 100.00% <0.00%> (+3.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0233756...2ad425d. Read the comment docs.

Copy link
Contributor

@hrzn hrzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@dennisbader dennisbader merged commit a7abedf into master Mar 19, 2022
@dennisbader dennisbader deleted the fix/covariate_slicing branch March 19, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ARIMA future covariates not working
3 participants