Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced new LinearLR scheduler (only available with torch >= 1.10.0)… #928

Merged
merged 1 commit into from
May 3, 2022

Conversation

dennisbader
Copy link
Collaborator

@dennisbader dennisbader commented Apr 24, 2022

Fixes #915

Summary

  • replaced LinearLR tests (only available for torch>=1.10.0) scheduler with StepLR (available from torch>=1.8.0)
  • moved save_hyperparameters() repetition into parent class PLForecastingModule

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #928 (18cadc1) into master (0d1a208) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
- Coverage   91.70%   91.70%   -0.01%     
==========================================
  Files          74       74              
  Lines        7404     7398       -6     
==========================================
- Hits         6790     6784       -6     
  Misses        614      614              
Impacted Files Coverage Δ
darts/models/forecasting/block_rnn_model.py 98.11% <ø> (-0.04%) ⬇️
darts/models/forecasting/nbeats.py 99.26% <ø> (-0.01%) ⬇️
darts/models/forecasting/nhits.py 98.42% <ø> (-0.02%) ⬇️
darts/models/forecasting/rnn_model.py 97.43% <ø> (-0.04%) ⬇️
darts/models/forecasting/tcn_model.py 96.80% <ø> (-0.04%) ⬇️
darts/models/forecasting/tft_model.py 96.79% <ø> (-0.02%) ⬇️
darts/models/forecasting/transformer_model.py 100.00% <ø> (ø)
darts/models/forecasting/pl_forecasting_module.py 93.07% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d1a208...18cadc1. Read the comment docs.

@dennisbader dennisbader merged commit fc09e50 into master May 3, 2022
@dennisbader dennisbader deleted the fix/torch_lr_scheduler branch May 3, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix torch dependency issue with minimal version
3 participants