-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Calibration logging for PEC #1873
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1873 +/- ##
===========================================
+ Coverage 0 98.53% +98.53%
===========================================
Files 0 79 +79
Lines 0 3694 +3694
===========================================
+ Hits 0 3640 +3640
- Misses 0 54 +54
|
@natestemen, thought I'd clarify that this PR is ready for review now (after a few false starts, oops!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, and good tests. Biggest request is getting the lines to print in a formatted way similar to ZNE, but most other stuff looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running an example using the light_pec_settings
from the tests it's printing out double headers.
The function name is also overflowing it's column. Do you think continuing to use a table here is the right choice if you want to print out the operations? I don't see a way that will fit in a text table.
Add logging test case for `PECSettings`, Update `print_line` function in `calibration.py` for compatibility with PEC
caa1abf
to
19318e6
Compare
Thanks for pointing this out @natestemen! Not sure how I missed this behavior before, but it turned out that the count determining whether to print the header "initially" was resetting with every "problem" instance. |
I propose to keep the table and remove the operations, since all 2-qubit op's are represented by default now when running PEC calibration. Working on this change plus some other improvements now. |
Add key for noise bias parameter in `Strategy` and propagate through code Make logging consistent with enhancement extending representations to all 2-qubit gates in circuit Improve formatting of logging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Misty! Thanks for working to ensure everything fits into the table nicely.
Description
Add Calibration logging for PEC.
Fixes #1861
A mixture of ZNE and PEC strategies is also supported in a simple way, as the appropriate header is printed initially and when the current technique is different from the previous technique.
License
Before opening the PR, please ensure you have completed the following where appropriate.