[Classical Shadows] quantum processing and test #1906

Min-Li · 2023-07-09T22:58:49Z

Description

z basis measurement and test from #1899

License

I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

I added unit tests for new code.
I used type hints in function signatures.
I used Google-style docstrings for functions.
I updated the documentation where relevant.
Added myself / the copyright holder to the AUTHORS file

…ement

github-actions · 2023-07-09T22:59:01Z

👈 Launch a binder notebook on branch Min-Li/mitiq/shadows/z-basis-measurement

…ement

add apidoc

…dows/rotation-gates

This reverts commit 517266f.

natestemen

@Min-Li it looks like a few of my previous comments were resolved without a change / comment. I unresolved a few of my previous comments. Please make sure to leave a comment if you are not going to make the requested change before resolving.

mitiq/shadows/quantum_processing.py

Co-authored-by: nate stemen <nate@stemen.email>

Min-Li · 2023-07-17T06:59:42Z

@natestemen Hi Nate, I resolved some conversations without leaving comments since I already address your comments in some previous commits. I will add comments before resolving conversations later.

nathanshammah

Thank @Min-Li, LGTM, for the api-doc part.

andreamari

Hi @Min-Li, good form my side. But please let's wait for Nate's approval before merging this PR.

I also left a suggestion to explain that the executor is expected to return a single shot.

mitiq/shadows/quantum_processing.py

Co-authored-by: Andrea Mari <andreamari84@gmail.com>

natestemen

Nice work Min. I think this is pretty much ready to go from my POV.

Please make sure to add tqdm to our dev_requirements.txt file.

mitiq/shadows/quantum_processing.py

natestemen · 2023-07-20T00:33:57Z

mitiq/shadows/test/test_quantum_processing.py

+@pytest.mark.parametrize("executor", [cirq_executor, qiskit_executor])
+def test_random_pauli_measurement_time_power_growth(
+    executor: Callable,
+):
+    """Test that random_pauli_measurement scales follow power law with the
+    number of measurements."""
+    n_qubits = [3, 6, 9, 12, 15]
+
+    times = []
+    for n in n_qubits:
+        qubits = cirq.LineQubit.range(n)
+        circuit = simple_test_circuit(qubits)
+        start_time = time.time()
+        random_pauli_measurement(
+            circuit,
+            100,  # number of total measurements
+            executor=executor,
+        )
+
+        times.append(time.time() - start_time)
+    for i in range(1, len(times)):
+        log_ratio_times = np.log(times[i] / times[i - 1])
+        log_ratio_qubits = np.log(n_qubits[i] / n_qubits[i - 1])
+        assert log_ratio_times == pytest.approx(log_ratio_qubits, rel=5)


Could we remove this test? It's quite slow, and it's not testing the correctness of the code. I ran pytest mitiq/shadows --durations=15 to get the tests ordered by speed in descending order.

==================================================================== slowest 15 durations ============================================= 13.96s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_time_power_growth[qiskit_executor] 3.96s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_time_growth[qiskit_executor] 1.14s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_time_power_growth[cirq_executor] 0.40s call mitiq/shadows/test/test_quantum_processing.py::test_generate_random_pauli_strings_time 0.30s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_output_types[qiskit_executor-2] 0.30s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_output_dimensions[qiskit_executor-5] 0.30s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_output_dimensions[qiskit_executor-2] 0.29s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_no_errors[qiskit_executor-5] 0.29s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_output_types[qiskit_executor-5] 0.28s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_no_errors[qiskit_executor-1] 0.27s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_no_errors[qiskit_executor-2] 0.20s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_output_types[qiskit_executor-1] 0.20s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_output_dimensions[qiskit_executor-1] 0.15s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_time_growth[cirq_executor] 0.01s call mitiq/shadows/test/test_quantum_processing.py::test_random_pauli_measurement_output_dimensions[cirq_executor-5]

Misty-W · 2023-07-20T00:54:41Z

Nice work Min. I think this is pretty much ready to go from my POV.

Please make sure to add tqdm to our dev_requirements.txt file.

@natestemen, @Min-Li, I hesitate to add a new dependency to Mitiq. My understanding is that tqdm is a status bar, please correct me if I'm missing something. Is there a particular reason why a status bar is a "must have" for Classical Shadows?

nathanshammah · 2023-07-20T13:14:30Z

Wanted just to comment that the errors in CI in build-docs occurred in the bqskit tutorial. As they are unrelated to these changes, they can be disregarded.

…` if len(result.get_counts().keys()) > 1: assert len(result.get_counts().keys()) == 1, ( "The `executor` must return a `MeasurementResult`" " for a single shot" )`

Co-authored-by: nate stemen <nate@stemen.email>

natestemen

Thanks for your patience Min. This looks good! 🚢

andreamari

After updating the warning in the function docstring consistently with the new ValueError, this looks good to me!

mitiq/shadows/quantum_processing.py

Co-authored-by: Andrea Mari <andreamari84@gmail.com>

Min-Li · 2023-07-21T16:43:10Z

@Misty-W Hey Misty, thanks for your comment
,"My understanding is that tqdm is a status bar, please correct me if I'm missing something. " yes, you are right,
"Is there a particular reason why a status bar is a "must have" for Classical Shadows?" This measurement may contain more than the number of hundred thousand measurements, depending on the number of qubits in the circuit, error rates, failer rate, and observables. This could be quite long progress, and without giving any hints of the progress bar, I am concerned about the user might kill the ongoing progress.
But I have made the tqdm an optional package, even if the user doesn't have it, it would be definitely okay. So we do not need to add it as a dependency.

Min-Li added 6 commits July 9, 2023 15:05

rotation gate function and tests

a1924b5

executor functions and tests

de2a2ae

adjust executor.py for computational basis measurements

517266f

Merge branch 'shadows/executor-functions' into shadows/z-basis-measur…

bdcf051

…ement

Merge branch 'feature/executor' into shadows/z-basis-measurement

908a4a5

z-basis measurement and unit test

6c3992f

Min-Li added the classical-shadows label Jul 9, 2023

Min-Li requested review from natestemen, nathanshammah, andreamari and Misty-W July 9, 2023 22:58

Min-Li self-assigned this Jul 9, 2023

Min-Li and others added 9 commits July 9, 2023 19:50

reformat

0a7ec44

reformat

d2a0e84

reformat

079c458

reformat

e4405c9

reformat

7d37df8

Merge branch 'shadows/executor-functions' into shadows/z-basis-measur…

38a7e46

…ement

Merge branch 'shadows/rotation-gates' into shadows/z-basis-measurement

a0ec96e

add apidoc

fd06e83

Merge pull request #1 from nathanshammah/Min-Li-shadows/rotation-gates

0b77e27

add apidoc

Min-Li changed the title ~~[Classical Shadows] Z-basis measurement and test~~ [Classical Shadows 2] Z-basis measurement and test Jul 10, 2023

Min-Li added 7 commits July 10, 2023 12:09

modify test

b66883b

Merge remote-tracking branch 'origin/shadows/rotation-gates' into sha…

5244034

…dows/rotation-gates

formate

7f63333

Revert "adjust executor.py for computational basis measurements"

aee1736

This reverts commit 517266f.

executor.evaluate --> executor.run

3714d23

reformat

e1dea5f

modify test

9b2aebd

natestemen reviewed Jul 16, 2023

View reviewed changes

mitiq/shadows/quantum_processing.py Outdated Show resolved Hide resolved

Min-Li and others added 2 commits July 16, 2023 23:19

Update mitiq/shadows/quantum_processing.py

237c71e

Co-authored-by: nate stemen <nate@stemen.email>

Update mitiq/shadows/test/test_quantum_processing.py

ff7fa1a

Co-authored-by: nate stemen <nate@stemen.email>

nathanshammah approved these changes Jul 17, 2023

View reviewed changes

andreamari approved these changes Jul 17, 2023

View reviewed changes

mitiq/shadows/quantum_processing.py Outdated Show resolved Hide resolved

nathanshammah removed the request for review from Misty-W July 17, 2023 15:18

reformat

f35294b

Min-Li requested a review from natestemen July 17, 2023 15:42

Min-Li and others added 6 commits July 17, 2023 08:53

Update mitiq/shadows/quantum_processing.py

67f551d

Co-authored-by: Andrea Mari <andreamari84@gmail.com>

reformat and apply Andrea's suggestion.

91978c8

reformat and apply Andrea's suggestion.

985cf58

remove pytest.fixture

9a7e5ec

reformat

3ec3522

remove trailing comma

77da824

Min-Li mentioned this pull request Jul 18, 2023

[Classical Shadows 4] Main function #1921

Merged

6 tasks

natestemen reviewed Jul 20, 2023

View reviewed changes

remove and add a test function, add the assert lines for measurement …

fbea926

…` if len(result.get_counts().keys()) > 1: assert len(result.get_counts().keys()) == 1, ( "The `executor` must return a `MeasurementResult`" " for a single shot" )`

Min-Li requested a review from natestemen July 20, 2023 22:22

Min-Li and others added 3 commits July 20, 2023 18:17

add an error lines for measurement `

69dc723

removed all test w.r.t time linearity, and power law.

5ebbdd8

Apply suggestions from code review

014de97

Co-authored-by: nate stemen <nate@stemen.email>

natestemen approved these changes Jul 21, 2023

View reviewed changes

andreamari approved these changes Jul 21, 2023

View reviewed changes

mitiq/shadows/quantum_processing.py Outdated Show resolved Hide resolved

Update mitiq/shadows/quantum_processing.py

206b28f

Co-authored-by: Andrea Mari <andreamari84@gmail.com>

Min-Li merged commit 536d1a0 into unitaryfund:master Jul 21, 2023

natestemen mentioned this pull request Jul 27, 2023

Add sampling functions for classical shadows #1878

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Classical Shadows] quantum processing and test #1906

[Classical Shadows] quantum processing and test #1906

Min-Li commented Jul 9, 2023

github-actions bot commented Jul 9, 2023

natestemen left a comment

Min-Li commented Jul 17, 2023

nathanshammah left a comment

andreamari left a comment

natestemen left a comment

natestemen Jul 20, 2023

Misty-W commented Jul 20, 2023

nathanshammah commented Jul 20, 2023

natestemen left a comment

andreamari left a comment

Min-Li commented Jul 21, 2023

[Classical Shadows] quantum processing and test #1906

[Classical Shadows] quantum processing and test #1906

Conversation

Min-Li commented Jul 9, 2023

Description

License

github-actions bot commented Jul 9, 2023

natestemen left a comment

Choose a reason for hiding this comment

Min-Li commented Jul 17, 2023

nathanshammah left a comment

Choose a reason for hiding this comment

andreamari left a comment

Choose a reason for hiding this comment

natestemen left a comment

Choose a reason for hiding this comment

natestemen Jul 20, 2023

Choose a reason for hiding this comment

Misty-W commented Jul 20, 2023

nathanshammah commented Jul 20, 2023

natestemen left a comment

Choose a reason for hiding this comment

andreamari left a comment

Choose a reason for hiding this comment

Min-Li commented Jul 21, 2023