[Classical Shadows 1] utils for shadows and unit test #1907

Min-Li · 2023-07-09T23:04:51Z

Description

utils for shadows and unit test from #1899

License

I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

I added unit tests for new code.
I used type hints in function signatures.
I used Google-style docstrings for functions.
I updated the documentation where relevant.
Added myself / the copyright holder to the AUTHORS file

github-actions · 2023-07-09T23:05:01Z

👈 Launch a binder notebook on branch Min-Li/mitiq/shadows/utils

codecov · 2023-07-09T23:37:11Z

Codecov Report

Merging #1907 (9134067) into master (5b8a72b) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 9134067 differs from pull request most recent head a6c5793. Consider uploading reports for the commit a6c5793 to get more accurate results

@@            Coverage Diff             @@
##           master    #1907      +/-   ##
==========================================
- Coverage   98.47%   98.46%   -0.02%     
==========================================
  Files          79       81       +2     
  Lines        3682     3717      +35     
==========================================
+ Hits         3626     3660      +34     
- Misses         56       57       +1

Files Changed	Coverage Δ
mitiq/shadows/shadows_utils.py	`100.00% <100.00%> (ø)`
mitiq/shadows/test/test_shadows_utils.py	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

natestemen · 2023-07-12T03:01:05Z

It looks like some of the tests are failing on python 3.8 due to a failure in subscripting np.ndarray. As in the other PR (#1908 (comment)) we should try to use numpy.typing for type hints.

andreamari

Minor comments/suggestions

mitiq/shadows/shadows_utils.py

nathanshammah

Thanks @Min-Li, looks good to me, besides @andreamari's comments.

Co-authored-by: Andrea Mari <andreamari84@gmail.com>

natestemen

Nice work. Just some small clean up items from me.

mitiq/shadows/shadows_utils.py

Co-authored-by: nate stemen <nate@stemen.email>

…urements_opts_expectation_bound` as a standalone function

andreamari

From my side, LGTM! Thanks Min!

natestemen

Looking good! A few minor questions/comments.

mitiq/shadows/shadows_utils.py

mitiq/shadows/test/test_shadows_utils.py

mitiq/shadows/shadows_utils.py

mitiq/shadows/test/test_shadows_utils.py

mitiq/shadows/shadows_utils.py

utils for shadows and unit test

f14f5a8

Min-Li added the classical-shadows label Jul 9, 2023

Min-Li requested a review from nathanshammah July 9, 2023 23:04

Min-Li self-assigned this Jul 9, 2023

Min-Li added 3 commits July 9, 2023 20:32

reformat

f989876

reformat

730b84d

reformat

f17c6ae

Min-Li changed the title ~~[Classical Shadows] utils for shadows and unit test~~ [Classical Shadows 1f] utils for shadows and unit test Jul 10, 2023

Min-Li changed the title ~~[Classical Shadows 1f] utils for shadows and unit test~~ [Classical Shadows 1] utils for shadows and unit test Jul 10, 2023

Min-Li added 5 commits July 10, 2023 14:14

apidoc

822918c

format

f443174

format

6e030d2

format

ead2103

format

af9b008

Min-Li changed the title ~~[Classical Shadows 1] utils for shadows and unit test~~ [Classical Shadows] utils for shadows and unit test Jul 12, 2023

Min-Li added 4 commits July 11, 2023 21:59

rename numpy typing

3ff0cff

Update docstring for shadow_utils

33346da

add doc and header.

85620d5

fix test functions

e20db21

andreamari reviewed Jul 17, 2023

View reviewed changes

nathanshammah approved these changes Jul 17, 2023

View reviewed changes

Min-Li and others added 3 commits July 17, 2023 10:45

Update mitiq/shadows/shadows_utils.py

47e59c4

Co-authored-by: Andrea Mari <andreamari84@gmail.com>

Update mitiq/shadows/shadows_utils.py

4ea99bd

Co-authored-by: Andrea Mari <andreamari84@gmail.com>

reformat and apply Andrea's suggestion.

36d5a2f

Min-Li mentioned this pull request Jul 18, 2023

[Classical Shadows 4] Main function #1921

Merged

6 tasks

change docstring

89e84e8

natestemen approved these changes Jul 20, 2023

View reviewed changes

Min-Li and others added 3 commits July 21, 2023 09:33

Update mitiq/shadows/shadows_utils.py

2dc89bc

Co-authored-by: nate stemen <nate@stemen.email>

Update mitiq/shadows/shadows_utils.py

55566db

Co-authored-by: nate stemen <nate@stemen.email>

modify API-doc; rename functions; pull out shadow_norm from `n_meas…

a73d0ef

…urements_opts_expectation_bound` as a standalone function

Min-Li requested review from nathanshammah, andreamari and natestemen July 22, 2023 22:57

Add util function transform_to_cirq_paulistring and test

ccb4902

Min-Li mentioned this pull request Jul 23, 2023

[Classical Shadows 1] classical postprocessing #1908

Merged

6 tasks

resolve cirq PauliString typing issue

3016cac

Min-Li changed the title ~~[Classical Shadows] utils for shadows and unit test~~ [Classical Shadows 1] utils for shadows and unit test Jul 23, 2023

andreamari approved these changes Jul 24, 2023

View reviewed changes

Merge branch 'master' into shadows/utils

b1fe6aa

nathanshammah approved these changes Jul 24, 2023

View reviewed changes

make utils could evaluate operators w/ coefficients

a8c27b1

Min-Li requested review from andreamari and nathanshammah July 24, 2023 20:15

check format

6ebb810

natestemen reviewed Jul 25, 2023

View reviewed changes

mitiq/shadows/shadows_utils.py Outdated Show resolved Hide resolved

mitiq/shadows/test/test_shadows_utils.py Outdated Show resolved Hide resolved

mitiq/shadows/shadows_utils.py Outdated Show resolved Hide resolved

mitiq/shadows/shadows_utils.py Outdated Show resolved Hide resolved

Min-Li added 2 commits July 25, 2023 00:06

check format and add acknowlegement.

f1837f6

Remove cirq.PauliString option and its transform function.

8bf579c

Min-Li requested a review from natestemen July 26, 2023 23:36

natestemen reviewed Jul 27, 2023

View reviewed changes

mitiq/shadows/test/test_shadows_utils.py Show resolved Hide resolved

natestemen reviewed Jul 27, 2023

View reviewed changes

mitiq/shadows/shadows_utils.py Outdated Show resolved Hide resolved

Min-Li added 2 commits July 27, 2023 16:13

Merge branch 'master' into shadows/utils

6132c00

minor changes

9134067

Min-Li requested a review from natestemen July 28, 2023 16:26

update docstring

a6c5793

natestemen approved these changes Jul 31, 2023

View reviewed changes

natestemen merged commit 9e8c619 into unitaryfund:master Jul 31, 2023
18 of 19 checks passed

natestemen mentioned this pull request Aug 1, 2023

[Robust Shadow 2]Add few functions for robust shadow estimation #1940

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Classical Shadows 1] utils for shadows and unit test #1907

[Classical Shadows 1] utils for shadows and unit test #1907

Min-Li commented Jul 9, 2023

github-actions bot commented Jul 9, 2023

codecov bot commented Jul 9, 2023 •

edited

Loading

natestemen commented Jul 12, 2023

andreamari left a comment

nathanshammah left a comment

natestemen left a comment

andreamari left a comment

natestemen left a comment

[Classical Shadows 1] utils for shadows and unit test #1907

[Classical Shadows 1] utils for shadows and unit test #1907

Conversation

Min-Li commented Jul 9, 2023

Description

License

github-actions bot commented Jul 9, 2023

codecov bot commented Jul 9, 2023 • edited Loading

Codecov Report

natestemen commented Jul 12, 2023

andreamari left a comment

Choose a reason for hiding this comment

nathanshammah left a comment

Choose a reason for hiding this comment

natestemen left a comment

Choose a reason for hiding this comment

andreamari left a comment

Choose a reason for hiding this comment

natestemen left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 9, 2023 •

edited

Loading