Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken URLs #1912

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Update broken URLs #1912

merged 4 commits into from
Jul 12, 2023

Conversation

Min-Li
Copy link
Contributor

@Min-Li Min-Li commented Jul 10, 2023

Description

Update broken/outdated URLs which are currently breaking CI.

The original Semantic Scholar link for the mitiq paper got changed externally. Updated the link with the latest one.
@Min-Li Min-Li added the documentation Improvements or additions to documentation label Jul 10, 2023
@Min-Li Min-Li self-assigned this Jul 10, 2023
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch unitaryfund/mitiq/README-Update-URL

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1912 (6107fed) into master (3331c2a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1912   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          76       76           
  Lines        3520     3520           
=======================================
  Hits         3468     3468           
  Misses         52       52           

README.md Outdated Show resolved Hide resolved
natestemen and others added 2 commits July 11, 2023 11:21
The original URL is invalid now (it seems the the website is down), breaking the doc building auto-check. Updated URL with another webpage.
@natestemen natestemen changed the title Update URL in README.md Update broken URLs Jul 11, 2023
@purva-thakre
Copy link
Collaborator

purva-thakre commented Jul 11, 2023

I made a commit to check if the link I added is stable or not.

Undo the commit if this one also fails docs build. Here's a link to another option.

#1912 (comment)

@Min-Li
Copy link
Contributor Author

Min-Li commented Jul 12, 2023

Passed checks. @purva-thakre

Copy link
Member

@natestemen natestemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Min!

@natestemen natestemen merged commit 5e25812 into master Jul 12, 2023
@natestemen natestemen deleted the README-Update-URL branch July 12, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants