Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix asv benchmarks #1937

Merged
merged 1 commit into from
Jul 31, 2023
Merged

fix asv benchmarks #1937

merged 1 commit into from
Jul 31, 2023

Conversation

natestemen
Copy link
Member

Description

Does what it says on the 🥫.

Log

In #1825 I renamed a keyword argument in mitiq_cirq.compute_density_matrix. I missed this update when making the changes as I don't often check asv/benchmarks.


No need for double review, I've just assigned both of y'all since you will be on earlier than me. If this looks good, feel free to merge.

@natestemen natestemen added bug Something isn't working infrastructure For issues related to building, packaging, and continuous integration. labels Jul 31, 2023
@natestemen natestemen self-assigned this Jul 31, 2023
@natestemen natestemen added this to the 0.28.0 milestone Jul 31, 2023
@github-actions
Copy link

Binder 👈 Launch a binder notebook on branch unitaryfund/mitiq/nts-fix-asv

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1937 (3e877d6) into master (5b8a72b) will decrease coverage by 0.02%.
Report is 4 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1937      +/-   ##
==========================================
- Coverage   98.47%   98.46%   -0.02%     
==========================================
  Files          79       81       +2     
  Lines        3682     3717      +35     
==========================================
+ Hits         3626     3660      +34     
- Misses         56       57       +1     

see 3 files with indirect coverage changes

Copy link

@WrathfulSpatula WrathfulSpatula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, Nate, this looks harmless and minimal enough for me to feel comfortable approving. I don't know if you need another team member.

@natestemen
Copy link
Member Author

Thanks Dan!

@natestemen natestemen merged commit 654e57c into master Jul 31, 2023
21 of 22 checks passed
@natestemen natestemen deleted the nts-fix-asv branch July 31, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working infrastructure For issues related to building, packaging, and continuous integration.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants