Ensure BQSKit example runs #1962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1962 +/- ##
=======================================
Coverage 98.36% 98.36%
=======================================
Files 83 83
Lines 3982 3982
=======================================
Hits 3917 3917
Misses 65 65 |
natestemen
added
documentation
andreamari
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The BQSKit tutorial was originally added in #1489, and after a few modifications to get it running on the
1.0release of BQSKit, it was running smoothly. In mid-July theimport bqskitline started started complaining, giving the followingAttributeError.Andrea hot-fixed this by skipping code execution on the example in #1927.
Description
In working on this issue, I was not able to reproduce the import issue locally. I wonder if it is a Linux only issue. This PR resolves this issue by bumping the BQSKit version to the latest version (1.0.4).
fixes #1920