-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace black
, flake8
, and isort
with ruff
#2222
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2222 +/- ##
==========================================
- Coverage 98.28% 98.28% -0.01%
==========================================
Files 90 90
Lines 4259 4257 -2
==========================================
- Hits 4186 4184 -2
Misses 73 73 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nate, there are more arrays and tuples that are expanded into multiple lines, as well as arithmetic lines that are condensed into a single line.
Also, there is a question about running make format
before, rather than after make check-format
.
@bdg221 Thanks for finding those additional examples of exploded lists/tuples/args. I've now split the original commit into two (one for adding ruff, and another for running it) and rerun ruff on our codebase ensuring we have the correct config. All the unnecessary changes should be gone now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Description
Does what it says on the 🥫.
Motivation
It's what the cool kids are using... jk
Ruff consolidates both linting (flake8) and formatting (black and isort) into a single tool which is configurable via the
pyproject.toml
file (flake8 refuses to support this feature, despite it becoming the defacto standard). This PR also consolidates the makefile so only one command is needed for linting/formatting checks and one command for fixing those problems (if possible).Request from reviewer
I want to make sure that the formatting that was done is required, given the ruff configuration. As part of the review, can you
ruff
pyproject.toml
to your local machinemake format