Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qiskit-ibm-provider #2342

Merged

Conversation

andre-a-alves
Copy link
Contributor

Description

Removes qiskit-ibm-provider.

qiskit-ibm-provider is deprecated, and should be migrated to qiskit-ibm-runtime using the migration guide. The only use of qiskit-ibm-provider was in the docs, so this MR updates the docs to no longer use the deprecated module and drops the module from the mitiq[qiskit] requirements.

I let most of the examples send a circuit to IBM Quantum, and minor discrepancies in the code have been corrected from that as well.

This MR should also make dependabot MR #2306 unnecessary.


License

  • I license this contribution under the terms of the GNU GPL, version 3 and grant Unitary Fund the right to provide additional permissions as described in section 7 of the GNU GPL, version 3.

Before opening the PR, please ensure you have completed the following where appropriate.

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.22%. Comparing base (2ff8134) to head (ddf7147).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2342   +/-   ##
=======================================
  Coverage   98.22%   98.22%           
=======================================
  Files          87       87           
  Lines        4059     4059           
=======================================
  Hits         3987     3987           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andre-a-alves
Copy link
Contributor Author

I had to add the requirement for qiskit-ibm-provider back in for Pennylane on Python 3.9. A TODO is included to remove it when Pennylane gets upgraded.

Copy link
Contributor

@cosenal cosenal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@andre-a-alves
Copy link
Contributor Author

After upgrading Pennylane, qiskit-ibm-provider~=0.11.0 still needs to remain a requirement in requirements-pennylane.txt for Python 3.9 until qiskit-ibm-runtime is upgraded. The comment was updated.

@cosenal
Copy link
Contributor

cosenal commented May 10, 2024

Thanks for resolving the conflicts, @andre-a-alves, LGTM. Feel free to merge if you think it's ready to go.

@andre-a-alves andre-a-alves merged commit 6ff6c08 into unitaryfund:main May 10, 2024
16 checks passed
@andre-a-alves andre-a-alves deleted the aaa/remove_qiskit_ibm_provider branch May 10, 2024 13:16
cosenal pushed a commit that referenced this pull request Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants