Wait for child stream close events #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we waited just for the child process closed event, which was documented to be emitted when the streams where closed. With this commit, we wait for all of events. This is whistling in the dark, hoping for some magic that will fix the occasional truncated logs problem. This commit also includes some instrumentation to show the order that these events are received. The typical order seems to be: 1. "child stderr close" 2. "child stdout close" 3. "child process exit" 4. "child process close" However, sometimes the order is: 1. "child stderr close" 2. "child process exit" 3. "child process close" 4. "child stdout close" If log truncation happened only with child stdout, I might rationalize the this ordering of events could be the smoking gun for the bug. But we have been observing log truncation when cranking up the `debug` log output, which has been using `stderr`.
|
Matt, I'm tempted to merge this even though I am not confident it will help. Thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we waited just for the child process closed event,
which was documented to be emitted when the streams where closed.
With this commit, we wait for all of events.
This is whistling in the dark, hoping for some magic that will fix
the occasional truncated logs problem.
This commit also includes some instrumentation to show the order
that these events are received. The typical order seems to be:
However, sometimes the order is:
If log truncation happened only with child stdout, I might rationalize
the this ordering of events could be the smoking gun for the bug. But we have
been observing log truncation when cranking up the
debuglog output, whichhas been using
stderr.