fix proposal for issue 293 (resolving singletons in the root container) implemented on v5.x (5.10.3) #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 21, 2019 16:13
…t container and are always awailable. This fix address the situation when a singleton resolved in a child container, might become corrupt (if it held references to factories), when the child container was closed/disposed.
…t container and are always awailable, part 2. Includes fix to BuilderContext.Resolve() and some DRY-refactoring.
|
Hmm, looks like the "latest" from the v5.x branch is not able to complile due to some argument mismatch in the exception ctor... Not related to my changes. |
|
Unfortunately I have to decline this PR. As I explained in the original topic, this behavior is by design and should not be changed. |
ENikS
added a commit
that referenced
this pull request
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original problem is discussed here https://github.com/unitycontainer/unity/issues/293
This is a suggested fix, wich resolves run-time issues caused by it. I hope, it covers all cases, but please let me know if I missed something or my assumptions about the Resolve() flows are incorrect.