Fix regex callback match count

[ntrel]

See:
https://sourceforge.net/p/ctags/bugs/271/
https://sourceforge.net/p/ctags/bugs/320/

Note: This fix is from Geany. Copying @b4n.

[masatake]

Thank you. Could you prepare a unit test case which triggers unwanted result if a user runs ctags without your patch? I'm happy if you update　docs/f-tracking.rst, too.

[b4n]

@masatake I'm afraid there's no current parser in CTags that use addCallbackRegex() anymore. The last one seem to have been asm.c back in the 2002.
In Geany, the older PHP parser used it (and the fix here was for it), but was replaced by the new non-regex one since then.

So, what I'm saying is it's hard to check a feature that is not used by a parser with the current suite.

Whether the fact it's not used means it should be removed I'm not completely sure, because it's a way of doing a bit more than with plain regexes without a complete "real" parser.

[ntrel]

Could you prepare a unit test case which triggers unwanted result if a user runs ctags without your patch?

As Colomban said, its not clear how to do that. I understand it should be tested somehow though.

I'm happy if you update　docs/f-tracking.rst, too.

Now done, let me know if you want any changes to my wording. I also added a commit with more info about parser changes I could think of.

[ntrel]

I wonder if this bug is partly to blame for why no parsers use addCallbackRegex.

[masatake]

Sorry, my words are wrong.

I wanted you to write about both

https://sourceforge.net/p/ctags/bugs/271/
https://sourceforge.net/p/ctags/bugs/320/

in bugs subsection of exuberant-ctags section docs/f-tracking.rst.
Can I ask you this?

[masatake]

@b4n, thank you for input. I would like to keep the code even if it is used now.

[ntrel]

I wanted you to write about both ... in bugs subsection of exuberant-ctags

Now done.

[masatake]

Thank you.