Skip to content

update translations #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 7, 2016
Merged

update translations #54

merged 7 commits into from
Mar 7, 2016

Conversation

g1039
Copy link

@g1039 g1039 commented Mar 7, 2016

@miltontony @hodgestar Please review

@g1039
Copy link
Author

g1039 commented Mar 7, 2016

@miltontony Ready for review

hodgestar
hodgestar reviewed Mar 7, 2016
View reviewed changes
development.ini Outdated
rus_RU
kir_KG
bur_MM
pt_BR
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using three letter language codes for the other languages. Just checking that its okay to be using a two-letter code here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, lets use 3 letters everywhere

@hodgestar
Copy link

Left one question, otherwise looks good to me.

@hodgestar
Copy link

I've also suggested that we load kur_TR as ckb_IQ as the nearest equivalent that Babel supports (see http://www-01.sil.org/iso639-3/documentation.asp?id=kur -- ckb_IQ is the closest alternative that current Babel supports).

@g1039
Copy link
Author

g1039 commented Mar 7, 2016

@miltontony @hodgestar READY FOR REVIEW

@hodgestar
Copy link

👍

miltontony
miltontony reviewed Mar 7, 2016
View reviewed changes
springboard_iogt/locale/ara_AE/LC_MESSAGES/messages.po

#: springboard_iogt/utils.py:27
msgid "Free legal information & support"
msgid "Know and use them!"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TrevorOctober I have concern about this change - we'll need to reupload the english POT file and have Botswang update "Know and use them!" for all the translations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can still land though, but we'll have to do another PR with the new translations for this sentence

g1039 pushed a commit that referenced this pull request Mar 7, 2016
Merge pull request #54 from universalcore/feature/issue-53-import-poo…
4bbc7b1 
…tle-translations

update translations
@g1039 g1039 merged commit 4bbc7b1 into develop Mar 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@g1039 @hodgestar @miltontony