Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status message after cloning showing hyphen (-) instead of slash (/) #95

Closed
TechAkayy opened this issue Apr 5, 2023 · 4 comments
Closed

Comments

@TechAkayy
Copy link

Environment

Node: v18.12.1
Package: npx giget@latest

Reproduction

npx giget@latest gh:TechAkayy/icones

Describe the bug

image

Look closely at this screenshot:

Cloned repo - gh:TechAkayy/icones
Status message - Successfully cloned TechAkayy-icones to TechAkayy-icones

Additional context

No response

Logs

No response

@pi0
Copy link
Member

pi0 commented Oct 4, 2023

Hi dear @TechAkayy. Actually it is an expected behavior we auto generate a heaman friendly name from full resolved repository. You can provide directory name like npx giget@latest gh:TechAkayy/icones icons or use a template registry.

I am closing issue but if you feel there is something to improve, please ping me to reopen.

@pi0 pi0 closed this as completed Oct 4, 2023
@TechAkayy
Copy link
Author

Hi @pi0

Yes, that's correct. But I raised this issue about showing the source repo's name correctly. So, I would have expected the displayed message message to be -

Successfully cloned TechAkayy/icones to TechAkayy-icones

instead of..

Successfully cloned TechAkayy-icones to TechAkayy-icones

Trivial one, what do you think.

@pi0 pi0 reopened this Oct 5, 2023
@pi0
Copy link
Member

pi0 commented Dec 23, 2023

Hi. Checking back it again, it is actually correct behavior (well, kinda!).

Templates when resolved, will get a name. In case of git repositories, name is normalized with - to be stored in cache.

CLI output shows resolved name because the input source with / is already visible in CLI input by user!

You might make a custom CLI to change this behavior.

@pi0 pi0 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 23, 2023
@TechAkayy
Copy link
Author

Thanks @pi0 for the detailed reply 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants