Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/provenance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
check-provenance:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- uses: actions/checkout@v5
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5

The checkout action uses a tag reference @v5 instead of the commit hash format used by other workflows in this repository, creating an inconsistent security approach.

View Details

Analysis

Inconsistent GitHub Actions pinning in provenance.yml breaks security pattern

What fails: provenance.yml uses tag reference actions/checkout@v5 instead of commit hash pinning used by 4 other workflows, creating inconsistent security approach in the repository

How to reproduce:

grep "checkout@" .github/workflows/*.yml
# Shows 4 files using: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5  
# Shows 2 files using: actions/checkout@v5

Result: Inconsistent pinning approach - 4 workflows use secure commit hash pinning, 2 use mutable tag references

Expected: All workflows should use the same commit hash format for consistency and security, per StepSecurity best practices which recommends commit hash pinning for immutability against supply chain attacks

with:
fetch-depth: 0
- name: Check provenance downgrades
Expand Down