fix: correct path handling for * exports in scanExports when exporting from module
#354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of relative paths Fixed #353
kiki-kanri
changed the title
scanExports resolves * exports to module paths instead of relative pathsscanExports when exporting from module
antfu
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #353
There is a file
/path/exports.tswith the following export:export * from 'axios'. The expected behavior is to automatically export all named and default exports from the axios module. However, the original behavior did not treat axios as a module and instead attempted to resolve it as/path/axios.tsor other files with various extensions.This PR fixes the issue.