Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update vue.ts, add vue3.4 3.5 api #370

Merged
merged 3 commits into from
Sep 12, 2024
Merged

feat: Update vue.ts, add vue3.4 3.5 api #370

merged 3 commits into from
Sep 12, 2024

Conversation

luvletterldl
Copy link
Contributor

@luvletterldl luvletterldl commented Sep 4, 2024

vue3.4: useModel vue3.5: useId, onWatcherCleanup, useTemplateRef

@@ -86,5 +86,14 @@ export default defineUnimportPreset({
'onRenderTriggered',
'resolveComponent',
'useCssVars',

// vue3.4+
'defineModel',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defineModel seems to be a compile-time macros that doesn't need to be imported

@antfu antfu merged commit 961399c into unjs:main Sep 12, 2024
3 checks passed
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.18%. Comparing base (a4a5e0a) to head (a1c4c2c).
Report is 33 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #370      +/-   ##
==========================================
- Coverage   98.73%   97.18%   -1.56%     
==========================================
  Files          14       13       -1     
  Lines        1817     1206     -611     
  Branches      374      389      +15     
==========================================
- Hits         1794     1172     -622     
- Misses         23       34      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants