Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding lock icons #216

Merged
merged 1 commit into from
Aug 31, 2018
Merged

adding lock icons #216

merged 1 commit into from
Aug 31, 2018

Conversation

julien51
Copy link
Member

No description provided.

@julien51 julien51 requested a review from benwerd August 31, 2018 19:58
@todo
Copy link

todo bot commented Aug 31, 2018

Customize position of circles

In order to get more unique lock icons we should also position (x, y and z) the inner circles


* @todo Customize position of circles
* @body In order to get more unique lock icons we should also position (x, y and z) the inner circles
* more uniquely based on the lock address... the challenge is to not have any white space.
* @param {lock} lock
*/
const Icon = ({ lock }) => {


This comment was generated by todo based on a @todo comment in b31941a in #216. cc @unlock-protocol.

@unlock-protocol unlock-protocol deleted a comment from todo bot Aug 31, 2018
@julien51
Copy link
Member Author

screen shot 2018-08-31 at 15 58 28

@benwerd
Copy link
Contributor

benwerd commented Aug 31, 2018

This is really cool. I think a potential future upgrade might be for contrast and readability - the yellow in particular seems really faint to me. But LG!

@julien51
Copy link
Member Author

Great point. Maybe we can find ways to do that algorithmically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants