Initial commit for creator lock component and stories #244
Conversation
add USD values to lockunlock/unlock-app/src/components/creator/CreatorLock.js Lines 17 to 22 in 56a7d2c This comment was generated by todo based on a
|
|
|
| // TODO add USD values to lock | ||
| // TODO add all-time balance to lock | ||
| return ( | ||
| <CreatorLockRow> |
There was a problem hiding this comment.
Would it be worth splitting that in multiple files eventually? All importing the same elements from below?
There was a problem hiding this comment.
Also, not sure it is worth prefixing Creator on all of these components?
There was a problem hiding this comment.
I wanted to keep the namespace clear for user-facing components, as these are all creator-facing UI elements. But I could change some of the names?
There was a problem hiding this comment.
Could totally split this up into multiple files though.
There was a problem hiding this comment.
I'll do exactly that in a follow-up PR.
There was a problem hiding this comment.
About the naming, I think one of the great thing about the styled components approach is that everything is scoped basically. Thesr components should but be reused.
| export function CreatorLock({ lock, status = 'deployed' }) { | ||
| // Some sanitization of strings to display | ||
| let name = lock.name || 'New Lock' | ||
| let displayAddress = lock.address ? lock.address.substr(0, 16) : '' |
There was a problem hiding this comment.
Wouldn;t it be better to use CSS for this?
| const inWei = Web3Utils.toWei(amount || '0', unit) | ||
| const inEth = Web3Utils.fromWei(inWei, 'ether') | ||
| return (<span>Ξ {inEth}</span>) | ||
| export function Balance({ amount, unit = 'wei', symbol=true }) { |
There was a problem hiding this comment.
Do you mind adding a test for this? (I think the Balance component has tests?)
| @@ -1,7 +1,7 @@ | |||
| import React from 'react' | |||
|
|
|||
| const Eth = props => ( | |||
| <svg viewBox="0 0 7 11" width="1em" height="1em" {...props}> | |||
There was a problem hiding this comment.
nope... these are automatically generated so we cannot change the values in there (I need to find a way to indicate that).
If you need the icons to be larger just change the font-size of the element in which the icons are displayed.
|
Updated. New screenshots:
|
|
Okay. Tests and reformatting completed. I'll follow up with splitting up into smaller components. PTAL. |
This PR contains the saved and confirming states for the lock from the creator side.
There are a few known issues that will need to be added in a following PR:
I've also added TODOs for the exchange rate values of the lock, and have kept the styles for those values commented out for now.