-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cupertino tabbar sliding #605
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajamatt
force-pushed
the
dev/mara/fix-cupertino-tabbar-sliding
branch
2 times, most recently
from
June 14, 2023 16:36
65b8534
to
ae0be0e
Compare
kazo0
reviewed
Jun 19, 2023
....Toolkit.Samples/Uno.Toolkit.Samples.Shared/Content/Controls/SegmentedControlSamplePage.xaml
Outdated
Show resolved
Hide resolved
src/library/Uno.Toolkit.Cupertino/Styles/Controls/SlidingSegmentedControl.xaml
Show resolved
Hide resolved
fix: added for mobile too fix: cupertino tabbar sliding test: android dispatcher for selection indicator Revert "test: android dispatcher for selection indicator" This reverts commit e23a3fb. revert fix: cupertino tabbar sliding refactor: some style attributes fix: cupertino tabbar sliding fix: adding back template fix: put template last fix: reverting changes + height fix fix: cupertino tabbar sliding
rajamatt
force-pushed
the
dev/mara/fix-cupertino-tabbar-sliding
branch
from
June 27, 2023 15:39
bc9d594
to
c1e907c
Compare
kazo0
approved these changes
Jul 19, 2023
@Mergifyio backport legacy/3x
|
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 15, 2023
fix: added for mobile too fix: cupertino tabbar sliding test: android dispatcher for selection indicator Revert "test: android dispatcher for selection indicator" This reverts commit e23a3fb. revert fix: cupertino tabbar sliding refactor: some style attributes fix: cupertino tabbar sliding fix: adding back template fix: put template last fix: reverting changes + height fix fix: cupertino tabbar sliding (cherry picked from commit 84f5ef9)
agneszitte
pushed a commit
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #524
PR Type
What kind of change does this PR introduce?
What is the new behavior?
CupertinoSlidingSegmentedStyle
to not use the old SelectionIndicatorPR Checklist
Please check if your PR fulfills the following requirements: