Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cupertino tabbar sliding #605

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Conversation

rajamatt
Copy link
Contributor

@rajamatt rajamatt commented Jun 12, 2023

GitHub Issue (If applicable): closes #524

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

  • Cupertino TabBar selector now is visually correct (selects the correct index).
  • Added CornerRadius of 8 for base TabBar.
  • Refactored CupertinoSlidingSegmentedStyle to not use the old SelectionIndicator

PR Checklist

Please check if your PR fulfills the following requirements:

cupertino_sliding

@rajamatt rajamatt self-assigned this Jun 13, 2023
@rajamatt rajamatt force-pushed the dev/mara/fix-cupertino-tabbar-sliding branch 2 times, most recently from 65b8534 to ae0be0e Compare June 14, 2023 16:36
fix: added for mobile too

fix: cupertino tabbar sliding

test: android dispatcher for selection indicator

Revert "test: android dispatcher for selection indicator"

This reverts commit e23a3fb.

revert

fix: cupertino tabbar sliding

refactor: some style attributes

fix: cupertino tabbar sliding

fix: adding back template

fix: put template last

fix: reverting changes + height fix

fix: cupertino tabbar sliding
@rajamatt rajamatt force-pushed the dev/mara/fix-cupertino-tabbar-sliding branch from bc9d594 to c1e907c Compare June 27, 2023 15:39
@kazo0 kazo0 merged commit 84f5ef9 into main Jul 19, 2023
@kazo0 kazo0 deleted the dev/mara/fix-cupertino-tabbar-sliding branch July 19, 2023 14:07
@unoplatform unoplatform deleted a comment from welcome bot Aug 15, 2023
@unoplatform unoplatform deleted a comment from pictos Aug 15, 2023
@agneszitte
Copy link
Contributor

agneszitte commented Aug 15, 2023

@Mergifyio backport legacy/3x

GitHub
Automate your pull requests. Mergify has 21 repositories available. Follow their code on GitHub.

@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

backport legacy/3x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 15, 2023
fix: added for mobile too

fix: cupertino tabbar sliding

test: android dispatcher for selection indicator

Revert "test: android dispatcher for selection indicator"

This reverts commit e23a3fb.

revert

fix: cupertino tabbar sliding

refactor: some style attributes

fix: cupertino tabbar sliding

fix: adding back template

fix: put template last

fix: reverting changes + height fix

fix: cupertino tabbar sliding
(cherry picked from commit 84f5ef9)
agneszitte pushed a commit that referenced this pull request Aug 15, 2023
Co-authored-by: Matthew Rajala <70542961+rajamatt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Gallery][Wasm/Android/iOS] sliding is not working properly for 'CupertinoSlidingSegmentedStyle'.
3 participants