fix: Templatebound Margin to remove hardcoded margin #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nguyeenvy can you point where is/are the change(s), there's a lot of noise caused by code-style |
@pictos As a tip when reviewing directly on GitHub you can use the "Hide whitespace" option |
agneszitte
reviewed
Aug 11, 2023
src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
Show resolved
Hide resolved
|
The main changes are at lines 218 and 223. |
Xiaoy312
approved these changes
Aug 17, 2023
agneszitte
approved these changes
Aug 30, 2023
agneszitte
deleted the
dev/vyng/Hardcoded-Margin-ElevatedCardContentControl
branch
|
@Mergifyio backport legacy/3x release/stable/3.1 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit df9e747) # Conflicts: # src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit df9e747) # Conflicts: # src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
jeromelaban
pushed a commit
that referenced
this pull request
Aug 30, 2023
(cherry picked from commit df9e747) # Conflicts: # src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
agneszitte
added a commit
that referenced
this pull request
Aug 31, 2023
(cherry picked from commit df9e747) # Conflicts: # src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
agneszitte
added a commit
that referenced
this pull request
Aug 31, 2023
(cherry picked from commit df9e747) # Conflicts: # src/library/Uno.Toolkit.Material/Styles/Controls/v2/CardContentControl.xaml
agneszitte
added a commit
that referenced
this pull request
Aug 31, 2023
agneszitte
added a commit
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #706
GitHub Issue (If applicable): #706
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Adding Elevated CardContentControls to an ItemsRepeater that defines its own Spacing between items causes more spacing between the cards than intended because of the margin applied to the ElevatedView
What is the new behavior?
The margin applied to the ElevatedView is now templatebound to Margin so we can set Margin=0 whenever we just want to use Spacing of the container around the CardContentControls.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):