Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Add support for FolderPicker #3916

Closed
12 of 18 tasks
Arlodotexe opened this issue Aug 31, 2020 · 3 comments
Closed
12 of 18 tasks

[Epic] Add support for FolderPicker #3916

Arlodotexe opened this issue Aug 31, 2020 · 3 comments
Assignees
Labels
difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding epic kind/enhancement New feature or request project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)

Comments

@Arlodotexe
Copy link
Contributor

Arlodotexe commented Aug 31, 2020

What would you like to be added:

Support for the FolderPicker on all platforms.

Why is this needed:

So the API can be used cross platform.

Child issues

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • macOS
  • Skia
    • WPF
    • GTK (Linux)
  • Windows
  • Build tasks
  • Solution Templates
@Arlodotexe Arlodotexe added kind/enhancement New feature or request triage/untriaged Indicates an issue requires triaging or verification labels Aug 31, 2020
@jeromelaban jeromelaban removed the triage/untriaged Indicates an issue requires triaging or verification label Aug 31, 2020
@Arlodotexe
Copy link
Contributor Author

Pasting my comment from here, as its relevant.

There is a Native File System API which is implemented in Chromium browsers, and can be enabled via a flag, though the W3C spec is still marked as a Draft. Mozilla seems to be working on the spec as well (see here).

For early adopters, it could be worth adding FileOpenPicker support via this API. When the Native File System API is finalized, should the API interfaces change, they can be updated in Uno.

edit: Looking into it further, "Original trial" means you need to request a token from Google to use the API before it's ready. The token is locked to a specific origin, has a usage limit, and the entire feature will be disabled (e.g. they outright remove the flag) if used by more than 0.5% of all Chrome page loads. So it won't be feasible to add this for everyone in WASM right now.

@agneszitte agneszitte added the project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui) label Sep 21, 2020
@Arlodotexe
Copy link
Contributor Author

Looks like the API has finished their origin trial and can be implemented.

However, it should be noted that this API still doesn't have a W3C standard and isn't on the standards track. Could be useful to interface through a JS library (if possible) for polyfills (such as this one).

@carldebilly carldebilly added this to the 3.4 milestone Nov 11, 2020
Arlodotexe added a commit to Arlodotexe/uno that referenced this issue Nov 28, 2020
Arlodotexe added a commit to Arlodotexe/uno that referenced this issue Nov 28, 2020
@carldebilly carldebilly removed this from the 3.4 milestone Nov 30, 2020
MartinZikmund pushed a commit to Arlodotexe/uno that referenced this issue Jan 21, 2021
@MartinZikmund MartinZikmund changed the title Add support for FolderPicker [Epic] Add support for FolderPicker Feb 12, 2021
@MartinZikmund MartinZikmund self-assigned this Feb 12, 2021
@MartinZikmund MartinZikmund added this to the 3.6 milestone Feb 12, 2021
@jeromelaban jeromelaban added the difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. label Feb 15, 2021
@MartinZikmund MartinZikmund added difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding and removed difficulty/tbd Categorizes an issue for which the difficulty level needs to be defined. labels Feb 28, 2021
@MartinZikmund MartinZikmund modified the milestones: 3.6, 3.7 Mar 22, 2021
@MartinZikmund MartinZikmund removed this from the 3.7 milestone Apr 1, 2021
@MartinZikmund
Copy link
Member

Closing, only missing folder pickers are GTK, WPF and Tizen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty/challenging 🤯 Categorizes an issue for which the difficulty level is reachable with internals understanding epic kind/enhancement New feature or request project/non-ui ⚙️ Categorizes an issue or PR as relevant to winrt (non-ui)
Projects
None yet
Development

No branches or pull requests

5 participants