AutoSuggestBox works on Android #1069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trap invalid item requests from BufferViewCache in managed code
Handle 0-height items more gracefully (ie, don't crash). Seems like 0-height items can occur temporarily in certain scenarios (ListViewItem doesn't have Template because Style isn't applied yet, but ContentControl.IsContentPresenterBypassEnabled recognises that it *will* have a template, and therefore doesn't materialize an ImplicitTextBlock.)
Allow user to keep typing after suggestions appear. This is still somewhat limited relative to UWP, eg trying to change the position of the cursor will close the suggestions dropdown.
This fixes crashes on Android from inconsistent state caused by measuring the native RecyclerView before it has been notified of added items.
NicolasChampagne
approved these changes
Jun 13, 2019
dr1rrb
approved these changes
Jun 13, 2019
...sApp/UITests.Shared/Windows_UI_Xaml_Controls/AutoSuggestBoxTests/BasicAutoSuggestBox.xaml.cs
Outdated
Show resolved
Hide resolved
jeromelaban
approved these changes
Jun 13, 2019
Co-Authored-By: David <github.site@torick.net>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): fixes #1012
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):