Adjust vsix structure #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromelaban
force-pushed
the
dev/jela/addin-details
branch
2 times, most recently
from
b4f5d25
to
66b2e69
Compare
davidjohnoliver
approved these changes
Aug 7, 2018
| <TemplateData> | ||
| <Name>Uno Platform Solution</Name> | ||
| <Description>Uno Platform App Cross Platform XAML Solution</Description> |
There was a problem hiding this comment.
This is a word soup... What about 'Project templates for creating a cross-platform XAML app with the Uno Platform that targets UWP, Android, iOS, and WebAssembly.'
| @@ -14,6 +14,7 @@ | |||
| <EnableLocationBrowseButton>true</EnableLocationBrowseButton> | |||
| <CreateInPlace>true</CreateInPlace> | |||
| <Icon>__TemplateIcon.png</Icon> | |||
| <Hidden>true</Hidden> | |||
There was a problem hiding this comment.
Indentation is off. (Not a big deal, just pointing out because there are so many other whitespace changes)
| <TemplateData> | ||
| <Name>Uno Platform Solution</Name> |
There was a problem hiding this comment.
For consistency maybe we want to change this to something like 'Cross-platform app (Uno Platform)'
There was a problem hiding this comment.
Indeed, with added casing it seems.
carldebilly
approved these changes
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8, #19, #6.