Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skia): Support RTL FlowDirection #13524

Merged
merged 11 commits into from
Sep 11, 2023

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Sep 6, 2023

GitHub Issue (If applicable): Skia part of #21

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Copilot Summary

🤖 Generated by Copilot at 4cb7cb6

This pull request adds support for right-to-left (RTL) layout and text rendering to the Uno platform, especially for the Skia target. It introduces a new FlowDirection property to the FrameworkElement class and its subclasses, and applies a transformation matrix to the Visual of the elements based on their flow direction. It also updates the TextBlock and TextBox classes to handle RTL text alignment and input. It modifies several files in the src/Uno.UI and src/SamplesApp folders, and adds a new compilation symbol, SUPPORTS_RTL, to the project file.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/automation Categorizes an issue or PR as relevant to project automation labels Sep 6, 2023
This was referenced Sep 6, 2023
@Youssef1313 Youssef1313 marked this pull request as ready for review September 7, 2023 13:27
@MartinZikmund MartinZikmund merged commit b63a8a3 into unoplatform:master Sep 11, 2023
83 checks passed
@MartinZikmund
Copy link
Member

🥳🥳🥳

@Youssef1313 Youssef1313 deleted the rtl-skia branch September 11, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants