-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(skia): Support RTL FlowDirection #13524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/skia ✏️
Categorizes an issue or PR as relevant to Skia
area/automation
Categorizes an issue or PR as relevant to project automation
labels
Sep 6, 2023
Youssef1313
force-pushed
the
rtl-skia
branch
from
September 6, 2023 17:00
4cb7cb6
to
d6a5884
Compare
6 tasks
MartinZikmund
approved these changes
Sep 8, 2023
🥳🥳🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/automation
Categorizes an issue or PR as relevant to project automation
area/skia ✏️
Categorizes an issue or PR as relevant to Skia
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): Skia part of #21
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Copilot Summary
🤖 Generated by Copilot at 4cb7cb6
This pull request adds support for right-to-left (RTL) layout and text rendering to the Uno platform, especially for the Skia target. It introduces a new
FlowDirection
property to theFrameworkElement
class and its subclasses, and applies a transformation matrix to theVisual
of the elements based on their flow direction. It also updates theTextBlock
andTextBox
classes to handle RTL text alignment and input. It modifies several files in thesrc/Uno.UI
andsrc/SamplesApp
folders, and adds a new compilation symbol,SUPPORTS_RTL
, to the project file.PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):