Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Catalyst] Ensure LottieVisualSource is transparent #15335

Merged
merged 2 commits into from
Feb 3, 2024
Merged

fix: [Catalyst] Ensure LottieVisualSource is transparent #15335

merged 2 commits into from
Feb 3, 2024

Conversation

jeromelaban
Copy link
Member

GitHub Issue (If applicable): closes #15247

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the new behavior?

Ensures the LottieVisualPlayer on Catalyst has a transparent background.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.1

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Feb 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 2, 2024 •
edited
Loading

backport release/stable/5.1

✅ Backports have been created

@jeromelaban
Copy link
Member Author

@Mergifyio backport release/stable/5.0

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 2, 2024 •
edited
Loading

backport release/stable/5.0

✅ Backports have been created

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15335/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15335/index.html

@nventive-devops
Copy link
Contributor

The build 111190 found UI Test snapshots differences: android-28-net7: 0, android-28-net7-Snap: 56, ios: 22, ios-Snap: 495, skia-gtk-screenshots: 17, skia-wpf-screenshots: 15, wasm: 56, wasm-automated-net7.0-UWP-Default-automated: 32, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 1

Details

  • android-28-net7: 0 changed over 1

  • android-28-net7-Snap: 56 changed over 1050

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • MediaPlayerElement_Using_mkv_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mkv_Extension
    • MediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_Extension
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Slider_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Slider
    • Progress_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • RatingControl_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage_UITests_Microsoft_UI_Xaml_Controls_RatingControlTests_RatingControlPage
    • Automation_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name_UITests_Shared_Windows_UI_Xaml_Automation_AutomationProperties_Name
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Basic
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromMsAppData
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromStream_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_FromStream
    • Grid_Grid_with_Text_HorizontalAlignment_With_Margin_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_with_Text_HorizontalAlignment_With_Margin
    • BreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPage
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_NoSize_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_NoSize
    • Scrolling_Hosted_ScrollViewer_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_Hosted_ScrollViewer
    • Scrolling_ScrollViewer_Content_Smaller_Than_Viewport_UITests_Shared_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Content_Smaller_Than_Viewport
    • MUX_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage_UITests_Microsoft_UI_Xaml_Controls_SplitButtonTests_SplitButtonPage
    • MUX_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage_UITests_Shared_Microsoft_UI_Xaml_Controls_TreeViewTests_TreeViewPage
    • ColorPicker_ColorPickerSample_UITests_Microsoft_UI_Xaml_Controls_ColorPickerTests_ColorPickerSample

  • ios: 22 changed over 266

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TextBox_TextAlignment_Left_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment
    • TextBox_TextAlignment_Right_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment
    • ListView_ChangingText_Validation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListView_Changing_Text
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Keyboard_Textbox_NoScrollViewer_Validation_2_-_Remove_Focus_on_placeholderTextTextBox
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Keyboard_Textbox_NoScrollViewer_Validation_5_-_Remove_Focus_on_numberTextBox
    • ListView_ObservableCollection_Creation_Count_Removed_above
    • Screenshots_Image_Stretch_Alignment_Equal_Mode-3
    • Keyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBox
    • ListView_ObservableCollection_Creation_Count_Added
    • Keyboard_Textbox_NoScrollViewer_Validation_1_-_Remove_Focus_on_filledTextBox
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage
    • TextBox_TextAlignment_DetectFromContent_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment
    • TextBox_TextAlignment_Justify_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment
    • ListView_ObservableCollection_Creation_Count_Added_above
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • ContentPresenter_Template_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Template
    • TextBox_TextAlignment_Center_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment

  • ios-Snap: 495 changed over 1041

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Border_Border_AntiAlias_UITests_Windows_UI_Xaml_Controls_BorderTests_BorderAntiAlias
    • Border_Border_Simple_with_Opacity_Uno_UI_Samples_UITests_BorderTestsControl_Border_Simple_with_Opacity
    • Brushes_ImageBrushChangingCornerRadius_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushChangingCornerRadius
    • Buttons_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate_And_StackPanel_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate_And_StackPanel
    • ContentPresenter_ContentPresenter_LocalOverride_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_LocalOverride
    • ContentPresenter_ContentPresenter_Padding_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Padding
    • FlipView_FlipView_Images_UITests_Windows_UI_Xaml_Controls_FlipView_FlipView_Images
    • Flyouts_Flyout_Attached_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Attached
    • Flyouts_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage_UITests_Shared_Microsoft_UI_Xaml_Controls_RadioMenuFlyoutItemTests_RadioMenuFlyoutItemPage
    • Flyouts_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Content_ThemeResource_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_Content_ThemeResource
    • Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEvents
    • Gesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_DoubleTappedTests_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_DoubleTappedTests
    • Grid_Grid_Multi_Column_Span_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_Multi_Column_Span
    • Grid_Grid_RowSpan_Auto_WithText_Uno_UI_Samples_Content_UITests_GridTestsControl_Grid_RowSpan_Auto_WithText
    • ListView_ListViewContainerFromItem_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewContainerFromItem
    • ListView_ListViewDynamicOrientation_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewDynamicOrientation
    • ListView_ListViewFirstVisibleIndex_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewFirstVisibleIndex
    • ListView_ListViewResizable_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewResizable
    • ListView_ListViewScrollIntoViewSnapPoints_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewScrollIntoViewSnapPoints
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems

  • skia-gtk-screenshots: 17 changed over 1098

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Progress-WinUIProgressRing_Features.png
    • Progress-WindowsProgressRing_GH1220.png
    • Transform-TransformToVisual_Translate2d.png
    • ListView-ListViewSelectedItems.png
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • Microsoft.UI.Composition-RedirectVisual.png
    • Automation-AutomationProperties_Name.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • PipsPager-PipsPagerExamples.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-ProgressRingHeightTest.png
    • MUX-WinUIProgressRingPage.png
    • Progress-WinUIProgressRingPage.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Image-Image_Formats.png
    • Image-Image_Stretch_None.png
    • WinUI-PipsPagerExamples.png

  • skia-wpf-screenshots: 15 changed over 1098

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • ListView-ListViewSelectedItems.png
    • Microsoft.UI.Composition-CompositionVisualSurface.png
    • Microsoft.UI.Composition-RedirectVisual.png
    • Progress-WinUIProgressRingPage.png
    • PipsPager-PipsPagerExamples.png
    • MediaPlayerElement-Mini player.png
    • MUX-WinUIProgressRingPage.png
    • MUX-WinUIProgressRing_CustomSources.png
    • Progress-ProgressRingHeightTest.png
    • Progress-WindowsProgressRing_GH1220.png
    • Progress-WinUIProgressRing_CustomSources.png
    • Progress-WinUIProgressRing_Features.png
    • Microsoft.UI.Composition-CompositionMaskBrush.png
    • Transform-TransformToVisual_Translate2d.png
    • WinUI-PipsPagerExamples.png

  • wasm: 56 changed over 1046

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MUXControlsTestApp.NavigationViewCompactPaneLengthTestPage
    • MUXControlsTestApp.NavigationViewStretchPage
    • SamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelected
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Last_Item_Large
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListView_Padding
    • UITests.Microsoft_UI_Xaml_Controls.ProgressRing.WinUIProgressRing_CustomSources
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_ChangeView
    • UITests.Shared.Windows_UI_Xaml.Enability.BasicEnability
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DropDownPlacement
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_DataTemplateSelector
    • UITests.Windows_UI_Xaml_Controls.SymbolIconTests.SymbolIcon_Generic
    • SamplesApp.Samples.NavigationViewSample.NavigationViewSample
    • UITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPage
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_3gp_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Avi_Extension
    • MUXControlsTestApp.NavigationViewAnimationPage
    • MUXControlsTestApp.NavigationViewRS4Page
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewSelectedItems
    • UITests.Microsoft_UI_Xaml_Controls.NumberBoxTests.NumberBox_Header
    • UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Algmnt_Inf_Vertical

  • wasm-automated-net7.0-UWP-Default-automated: 32 changed over 1951

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Default_StrokeThickness_MyPolygon
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • MediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Minimal
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LineGeometry
    • Performance_Dopes_UITests_Windows_UI_Xaml_Performance_Performance_Dopes
    • Pickers_TimePicker_Flyout_Automated_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Progress_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_CustomSources
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • TextBlock_TextBoxSizeChanging_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBoxSizeChanging
    • PipsPager_MUXControlsTestApp_PipsPagerExamples_MUXControlsTestApp_PipsPagerExamples
    • When_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_SVG_Path
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_Dynamic_Geometries
    • Path_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry_UITests_Windows_UI_Xaml_Shapes_PathTestsControl_Path_EllipseGeometry

  • wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-2: 1 changed over 1

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • RunRuntimeTests_SamplesApp_Samples_UnitTests_UnitTestsPage

@jeromelaban jeromelaban merged commit 4632296 into master Feb 3, 2024
92 checks passed
@jeromelaban jeromelaban deleted the dev/jela/catalyst-lottie-opacity branch February 3, 2024 00:52
This was referenced Feb 3, 2024
Merged
Merged
jeromelaban added a commit that referenced this pull request Feb 5, 2024
@jeromelaban
Merge pull request #15341 from unoplatform/mergify/bp/release/stable/…
b815811 
…5.0/pr-15335

fix: [Catalyst] Ensure LottieVisualSource is transparent (backport #15335)
jeromelaban added a commit that referenced this pull request Feb 5, 2024
@jeromelaban
Merge pull request #15340 from unoplatform/mergify/bp/release/stable/…
8414151 
…5.1/pr-15335

fix: [Catalyst] Ensure LottieVisualSource is transparent (backport #15335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Mac Catalyst] [ProgresRing] Visualization issues
4 participants
@jeromelaban @unodevops @nventive-devops @ajpinedam