Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Switch to OpenSans #15958

Merged
merged 21 commits into from
Jul 10, 2024
Merged

feat: Switch to OpenSans #15958

merged 21 commits into from
Jul 10, 2024

Conversation

Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented Mar 20, 2024 •
edited by jeromelaban
Loading

GitHub Issue (If applicable): closes #3954, closes #17381

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/skia ✏️ Categorizes an issue or PR as relevant to Skia area/build Categorizes an issue or PR as relevant to build infrastructure labels Mar 20, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@jeromelaban jeromelaban mentioned this pull request Jun 3, 2024
Closed
@Youssef1313 Youssef1313 force-pushed the opensans branch 3 times, most recently from 0b10dcb to 537e312 Compare June 4, 2024 12:36
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Jun 5, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@Youssef1313 Youssef1313 marked this pull request as ready for review June 5, 2024 09:17
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@jeromelaban
Copy link
Member

jeromelaban commented Jun 6, 2024 •
edited
Loading

@Youssef1313 The missing failing test seems linked to the default font, specifically.

jeromelaban
jeromelaban reviewed Jun 6, 2024
View reviewed changes
src/Uno.UI/FeatureConfiguration.cs Outdated Show resolved Hide resolved
src/Uno.UI/UI/Xaml/FontFamily.cs Outdated Show resolved Hide resolved
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@ajpinedam ajpinedam mentioned this pull request Jun 19, 2024
Open
6 tasks
@Youssef1313 Youssef1313 marked this pull request as draft June 20, 2024 05:28
@github-actions github-actions bot added area/code-generation Categorizes an issue or PR as relevant to code generation area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk and removed area/build Categorizes an issue or PR as relevant to build infrastructure labels Jun 20, 2024
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@Youssef1313 Youssef1313 marked this pull request as ready for review July 9, 2024 19:17
@jeromelaban
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-15958/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-15958/index.html

@jeromelaban jeromelaban merged commit 9eba2d5 into unoplatform:master Jul 10, 2024
60 of 95 checks passed
@mergify mergify bot mentioned this pull request Jul 10, 2024
Merged
6 tasks
jeromelaban added a commit that referenced this pull request Jul 10, 2024
@jeromelaban
Merge pull request #17451 from unoplatform/mergify/bp/release/stable/…
7e3609c 
…5.3/pr-15958

feat: Switch to OpenSans (backport #15958)
@Youssef1313 Youssef1313 deleted the opensans branch July 10, 2024 19:42
This was referenced Jul 12, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agneszitte agneszitte agneszitte left review comments

@jeromelaban jeromelaban jeromelaban left review comments

@carldebilly carldebilly carldebilly approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/code-generation Categorizes an issue or PR as relevant to code generation area/sdk Categorizes an issue or PR as relevant to the Uno.Sdk kind/documentation
Projects
None yet
Milestone
No milestone
5 participants
@Youssef1313 @unodevops @jeromelaban @carldebilly @agneszitte