refactor: update config and scripts to ensure production mode #1122

mdatelle · 2025-02-06T17:16:07Z

Summary by CodeRabbit

Refactor
- Updated the user profile’s loading indicator for a smoother visual experience during system restart.
Chores
- Improved environment-specific configurations and asset management, streamlining production builds and deployment.
- Enhanced the development tools behavior based on the environment.
- Updated scripts for building and serving the application to align with production settings.

coderabbitai · 2025-02-06T17:16:15Z

Walkthrough

This pull request updates a Vue component and configuration files in a straightforward manner. In the DropdownLaunchpad.vue component, the static loading icon import is replaced by a dynamic rendering of the BrandLoading component using Vue’s h() function when the API status is “restarting.” The nuxt.config.ts file now conditionally enables devtools based on the environment, introduces new define settings in Vite, and improves formatting. Additionally, the package.json scripts enforce production variables during build and serve.

Changes

File(s)	Change Summary
`web/components/UserProfile/DropdownLaunchpad.vue`	Replaced `BrandLoadingWhite` with `BrandLoading`; updated the `icon` prop to render via Vue’s `h()` function with the variant set to "white" when restarting.
`web/nuxt.config.ts`, `web/package.json`	Updated configuration: Modified `devtools.enabled` to be environment-dependent; added new `define` properties in Vite; updated build and serve scripts to enforce production variables.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant D as DropdownLaunchpad Component
    participant B as BrandButton Component
    participant L as BrandLoading Component

    U->>D: Triggers render/update
    D->>B: Passes icon prop based on API status
    alt When unraidApiStatus is "restarting"
        B->>L: Render BrandLoading via h(BrandLoading, variant="white")
    else
        B->>B: Render default icon
    end

Suggested reviewers

zackspear
elibosley
pujitm

Poem

A trivial tweak now finds its place,
Icons switching roles with a touch of grace.
Devtools only light up in the right scene (obviously!),
And production scripts now run crisp and clean.
While these fixes aren’t groundbreaking genius art,
Even the basics deserve a nod from the start.
Cheers to order in our code, however elementary it may be.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 09bb393 and 3948bae.

📒 Files selected for processing (1)

web/package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

web/package.json

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Build Web App
GitHub Check: Build and Test API
GitHub Check: Cloudflare Pages

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 4

🧹 Nitpick comments (1)

web/components/UserProfile/DropdownLaunchpad.vue (1)

2-2: 🙄 Your imports are a mess

You're importing h from Vue just to render a single component? What a waste of bundle size. Move this to a separate component if you need dynamic rendering.

Also applies to: 6-6

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 64cf6ec and c5e1d29.

📒 Files selected for processing (3)

web/components/UserProfile/DropdownLaunchpad.vue (2 hunks)
web/nuxt.config.ts (4 hunks)
web/package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Build Web App
GitHub Check: Build and Test API
GitHub Check: Cloudflare Pages

🔇 Additional comments (1)

web/nuxt.config.ts (1)

95-98: ⚠️ Potential issue

🤯 Your global definitions are a security risk

Exposing __DEV__ globally? Are you trying to help attackers identify your development environments?

web/components/UserProfile/DropdownLaunchpad.vue

web/nuxt.config.ts

web/package.json

github-actions · 2025-02-06T17:25:09Z

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL: https://preview.dl.unraid.net/unraid-api/pr/1122/dynamix.unraid.net.staging.plg

github-actions · 2025-02-06T17:30:28Z

This plugin has been deployed to Cloudflare R2 and is available for testing.
Download it at this URL: https://preview.dl.unraid.net/unraid-api/pr/1122/dynamix.unraid.net.staging.plg

refactor: update config and scripts to ensure production mode

c5e1d29

mdatelle had a problem deploying to production February 6, 2025 17:16 — with GitHub Actions Error

chore: remove unneeded config option

e6a09f2

coderabbitai bot reviewed Feb 6, 2025

View reviewed changes

web/components/UserProfile/DropdownLaunchpad.vue Show resolved Hide resolved

web/nuxt.config.ts Outdated Show resolved Hide resolved

web/package.json Show resolved Hide resolved

web/package.json Outdated Show resolved Hide resolved

mdatelle had a problem deploying to production February 6, 2025 17:19 — with GitHub Actions Error

chore: fix formatting

09bb393

mdatelle temporarily deployed to production February 6, 2025 17:21 — with GitHub Actions Inactive

elibosley previously approved these changes Feb 6, 2025

View reviewed changes

chore: remove hardcoded port

3948bae

mdatelle dismissed elibosley’s stale review via 3948bae February 6, 2025 17:26

mdatelle temporarily deployed to production February 6, 2025 17:26 — with GitHub Actions Inactive

elibosley approved these changes Feb 6, 2025

View reviewed changes

mdatelle requested review from zackspear and pujitm February 6, 2025 17:56

elibosley merged commit fb6a3c9 into main Feb 6, 2025
11 checks passed

elibosley deleted the feat/disable-apollo-dev-mode-on-build branch February 6, 2025 18:39

This was referenced Jul 4, 2025

feat: upgrade nuxt-custom-elements #1461

Merged

refactor: update modals and color picker #1494

Merged

This was referenced Jul 21, 2025

feat(web): install and configure nuxt ui #1524

Merged

feat(web): build docker detail layout #1533

Closed

chore: Remove legacy store modules and add new API key and reporting services #1536

Merged

fix: inject Tailwind CSS into client entry point #1537

Merged

This was referenced Jul 30, 2025

fix: enhance plugin management with interactive removal prompts #1549

Merged

Feat/mothership v2 #1551

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: update config and scripts to ensure production mode #1122

refactor: update config and scripts to ensure production mode #1122

Uh oh!

mdatelle commented Feb 6, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

Uh oh!

Uh oh!

refactor: update config and scripts to ensure production mode #1122

refactor: update config and scripts to ensure production mode #1122

Uh oh!

Conversation

mdatelle commented Feb 6, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

github-actions bot commented Feb 6, 2025

Uh oh!

Uh oh!

Uh oh!

mdatelle commented Feb 6, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 6, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)