Delete messages matching the given regex. Fixes #32 #33
Conversation
icy95
changed the title
|
Would love to see this merged. Any ETA? @ibrahimcanyilmaz |
| @@ -54,4 +55,12 @@ if check_duplicate_msg == "true" | |||
| end | |||
| end | |||
|
|
|||
| if delete_prev_regex_msg != nil | |||
| coms.each do |n| | |||
There was a problem hiding this comment.
I believe it's possible for coms to be nil here (if check_duplicate_msg is false), making the script error out. Can someone have a look?
There was a problem hiding this comment.
Not sure if this the root but we are seeing an issue when we pass msg="something", check_for_duplicate_msg="false" and delete_prev_regex_msg="nil":
/entrypoint.sh:60:in
<main>': undefined methodeach' for nil:NilClass (NoMethodError)
There was a problem hiding this comment.
@genevieve Oh; because those get passed in as strings - "false", and "nil", not actually false and nil. Which means that they're truthy. Removing the params entirely will give you actual nil/falsey values.
There was a problem hiding this comment.
Ah it's because we use the image in a github action so even though we pass false or nothing, it will quote them before passing them as arguments to the docker command. Thanks, we'll drop them entirely.
There was a problem hiding this comment.
Actually, this is happening for us regardless of whether we rely on the defaults or not because of the way that the github action passes the values to the docker command. We weren't explicitly setting delete_prev_regex_msg and it would pass in "nil".
No description provided.