Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade maplibre to v3 #163

Closed
JinIgarashi opened this issue May 26, 2023 · 2 comments
Closed

chore: upgrade maplibre to v3 #163

JinIgarashi opened this issue May 26, 2023 · 2 comments
Assignees
Labels
breaking-change This issue or pull request will introduce a breaking change in the next release bug Something isn't working

Comments

@JinIgarashi
Copy link
Member

@smellman, @keichan34

Maplibre is now v3 which is not compatible with previous version and mapbox at all.
I tried to upgrade maplibre by myself, but I found a problem at getSpriteSlug function. Looks like the changes of multiple sprites support in v3 makes this function have an issue.

Could you please upgrade maplibre version to v3 at charites?

I upgraded maplibre to v3 at maplibre-gl-legend. Please use the following new CDN path when you will upgrade charites (I guess legend plugin included in current version of charites is no longer working)

<link
  href="https://www.unpkg.com/@watergis/maplibre-gl-legend@latest/dist/maplibre-gl-legend.css"
  rel="stylesheet"
/>
<script src="https://www.unpkg.com/@watergis/maplibre-gl-legend@latest/dist/maplibre-gl-legend.umd.js"></script>**

references

thanks

@JinIgarashi JinIgarashi added bug Something isn't working breaking-change This issue or pull request will introduce a breaking change in the next release labels May 26, 2023
@smellman
Copy link
Contributor

@smellman
Copy link
Contributor

I think dropping mapbox supports in next version because a test case can't run for mapbox.
Is it OK?

smellman added a commit to smellman/charites that referenced this issue May 29, 2023
smellman added a commit to smellman/charites that referenced this issue Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This issue or pull request will introduce a breaking change in the next release bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants