Skip to content

[CC-724] Add googlepay example #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

Ryouzanpaku
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Feb 5, 2024

Logo
Checkmarx One – Scan Summary & Details4e3d4299-50d9-4bcc-9600-ffa7ea8922fe

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Missing_HSTS_Header /examples/Googlepay/index.php: 144 Attack Vector
MEDIUM Privacy_Violation /src/Unzer.php: 679 Attack Vector
MEDIUM Privacy_Violation /src/Unzer.php: 679 Attack Vector
MEDIUM Privacy_Violation /src/Unzer.php: 679 Attack Vector
MEDIUM Session_Fixation /examples/Googlepay/Controller.php: 23 Attack Vector
LOW Client_Hardcoded_Domain /examples/Googlepay/index.php: 26 Attack Vector
LOW Missing_CSP_Header /examples/Googlepay/index.php: 140 Attack Vector

@Ryouzanpaku Ryouzanpaku requested a review from a team February 6, 2024 13:25
Comment on lines 136 to 162

return fetch(
'./Controller.php',
{
body: JSON.stringify(formObject),
method: 'POST'
}
)
.then(response => response.json())
.then( transactionResult => {
const status = transactionResult.transactionStatus;

if (status === 'success' || status === 'pending') {
if (transactionResult.redirectUrl.trim().length !== 0) {
window.location.href = transactionResult.redirectUrl;
} else {
window.location.href = '<?php echo RETURN_CONTROLLER_URL; ?>';
}
} else {
window.location.href = '<?php echo FAILURE_URL; ?>';
}
})
.catch(function (error) {
return handleGooglepayError(error);
}
)
})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is main part changed, compared to demo.

Copy link

@imperialowl imperialowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@Ryouzanpaku Ryouzanpaku merged commit 2bfe94d into develop Feb 7, 2024
@Ryouzanpaku Ryouzanpaku deleted the CC-724/googlepay-example branch February 7, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants