-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build in Ubuntu 23.04 #15
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tandard_args` (NABO) does not match the name of the calling package (Nabo)' by renaming the find nabo cmake file
…er than 11 are not supported! The nvcc flag '-allow-unsupported-compiler' can be used' issue is resolved
…this on one build system
10 tasks
Merged
Hi Lucas, thanks for your contributions! On top of your state, we made some changes so that lvr2 compiles with Ubuntu 22 and ROS2 - humble. The CUDA things are also compiling and running again. And it is already merged: #16. It seemed easier for us to do it this way. So this PR is not required anymore. Greetings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a few edits to make this build in 23.04 and eliminate some warnings but it's not quite there, cuda isn't working:
I thought the above may have been caused by forcing C++ to an older standard than the nvcc that is in 23.04 but possibly my system isn't set up properly.
If older Ubuntu versions (<18.04 or other non-Ubuntu systems?) are still being supported there could be more logic around those to restore setting
c++11
- but if only current LTS systems are targeted it should be safe to remove.