Support for the USB SICK TiM in ROS2 #100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix unprotected test See merge request ros-overlays/sick_tim!1
Replace Stratom linter for ROS2 common linter Make linter happy wrt file extensions Make linter happy using ament_uncrustify Disable copyright checks Make cpplint happy wrt. header guards Filter out picky whitespace cpplint errors Add lacking includes Fix lacking explicit keyword Fix cpplint warnings Fix cpplint: using c99 non-standard variable-length stacked-array Fix cpplint error: wrong colophon Fix cpplint: using c-style cast Fix cpplint: using C type short Fix cpplint: using non-reentrant strtok Fix flake8: unused imports Fix flake8: unused var Fix flake8: white spaces Fix cmake linter: white spaces Fix build: add boost dependency Fix typo
Fix warning about initialization order Fix unused variable warning initialize variable subscribe_datagram Fix warning: maybe be used uninitialized Fix warning: signed/unsigned comparison mismatch Fix warning: hex format specifier expects unsigned int
|
Please consider to create a separate branch to land this PR to |
Merged
|
I cancel this PR due to polluted git history. #101 replaces this one. Sorry for the mess |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Wpedanticintroduced by Stratom Inc.See #99 for further information