This repository has been archived by the owner on May 30, 2024. It is now read-only.
Make S3_BUCKET and publishing to it optional #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javad Taheri <taheri.javad@gmail.com>
soorena776
force-pushed
the
make_s3bucket_optional
branch
from
606a477
to
9dd596e
Compare
Signed-off-by: Javad Taheri <taheri.javad@gmail.com>
lukeweber
approved these changes
Mar 26, 2020
bassam
approved these changes
Mar 28, 2020
|
Merging this PR since it's been approved by 2 folks |
Merged
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WESAAS does not need publishing to an S3_BUCKET, so making it optional in
output.mkSigned-off-by: Javad Taheri taheri.javad@gmail.com