Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get CustomResourceDefinition from CompositeResourceDefinition #89

Closed
thephred opened this issue May 25, 2022 · 0 comments · Fixed by #106
Closed

Get CustomResourceDefinition from CompositeResourceDefinition #89

thephred opened this issue May 25, 2022 · 0 comments · Fixed by #106
Assignees
Labels
enhancement New feature or request needs-epic-link Needs a link to an epic needs-points-label Needs a story points label needs-project Needs to be added to a project board

Comments

@thephred
Copy link
Member

What problem are you facing?

The only way to get a CustomResourceDefinition is either to get it from the list of all resource definitions (customResourceDefinitions.nodes) or directly by id from kubernetesResource(id: $id). The list of all CRDs can be quite long and if the user is just wanted the CRDs the correspond to the CompositeResourceDefinitions fetching the whole is and expensive way to get them. The CompositeResourceDefinition does offer the apiVersion and kind of composite and claim CRDs via status.controllers.compositeResourceType and status.controllers.compositeResourceClaimType respectively but there is no way to fetch a CRD from that info.

How could Upbound help solve your problem?

If a CompositeResourceDefinition offered fields that returned the CRD for the claim and the composite resource this would be a much smaller list and a more performant way of getting these details. Also, it would be nice to be able to fetch a CRD from kind and apiVersion but this is not strictly needed currently.

@thephred thephred added enhancement New feature or request needs-project Needs to be added to a project board needs-epic-link Needs a link to an epic needs-points-label Needs a story points label labels May 25, 2022
@thephred thephred self-assigned this Sep 12, 2022
thephred added a commit to thephred/xgql that referenced this issue Sep 28, 2022
thephred added a commit to thephred/xgql that referenced this issue Oct 3, 2022
Resolves upbound#89

Co-authored-by: Daniel Mangum <31777345+hasheddan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs-epic-link Needs a link to an epic needs-points-label Needs a story points label needs-project Needs to be added to a project board
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant