Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DefaultBootstrap Option launchFirst not working #104

Closed
nkausche opened this issue Aug 19, 2020 · 1 comment
Closed

DefaultBootstrap Option launchFirst not working #104

nkausche opened this issue Aug 19, 2020 · 1 comment

Comments

@nkausche
Copy link
Contributor

nkausche commented Aug 19, 2020

I am new to Update4J and maybe I am totally wrong, but I tried to use the DefaultBoostrap with "--launchFirst" and it did not update at all.

java -cp update4j-1.4.5.jar org.update4j.Bootstrap --local update-config.xml --remote http://<server:port>/application/config.xml --syncLocal --launchFirst --singleInstance

Without "--launchFirst" it works fine.

I think I identified the issue with a blocking call to the application (see pull request).

This should have never worked in the first place. Did I miss something?

@nkausche nkausche changed the title launchFirst not working DefaultBootstrap Option launchFirst not working Aug 19, 2020
@mordechaim
Copy link
Contributor

mordechaim commented Aug 19, 2020

It does seem to be a bug indeed. But in the current implementation run() actually launches the business app, but instead of updating in parallel it blocks and completes the update on shutdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants