Skip to content

Add Netlify config for easier CRA deployment #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Add Netlify config for easier CRA deployment #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98acc0b
Add netlify config file
ProchaLu Sep 13, 2023
e5e7376
Add line break in Netlify config file
ProchaLu Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/cra-template/template/gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@
/coverage

# production
# /build
# Changed from /build to /dist because this is default for
# Netlify when deploying an app using `@upleveled/react-scripts`
# Ref: https://github.com/upleveled/create-react-app/commit/ab165a178994751e837d2835b2a4dbcc48f6f709#
/dist
/build

# misc
.DS_Store
Expand Down
3 changes: 3 additions & 0 deletions packages/cra-template/template/netlify.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
[build]
publish = "build"
command = "pnpm run build"
5 changes: 1 addition & 4 deletions packages/react-scripts/config/paths.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ const publicUrlOrPath = getPublicUrlOrPath(
process.env.PUBLIC_URL,
);

const buildPath =
process.env.BUILD_PATH ||
// Default for Netlify when deploying an app using `@upleveled/react-scripts`
'dist';
const buildPath = process.env.BUILD_PATH || 'build';

const moduleFileExtensions = [
'web.mjs',
Expand Down