docs: added describe props api, styles, react-uploader-api via ref (#14) #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* docs: added describe props api, styles, react-uploader-api via ref * feat: added className for wrapper * docs: added describe summary and Quick Features * feat: added userAgentIntegration
- @uploadcare/react-adapter@0.2.0 - @uploadcare/react-uploader@0.2.0
nd0ut
reviewed
Apr 29, 2024
| import { version, name } from "../../package.json"; | ||
|
|
||
| export const getUserAgentIntegration = (pubkey: string) => { | ||
| return `${name}/${version}/${pubkey} (JavaScript; React;)`; |
There was a problem hiding this comment.
This format seems to be invalid here. It should be just Integration/version; string.
Because blocks UA is blocks/${version}/${publicKey} (JavaScript; ${integration}) where integration is our string.
There was a problem hiding this comment.
Ok.
Output string: React/18.2.0; @uploadcare/react-uploader/0.2.0
nd0ut
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: added describe props api, styles, react-uploader-api via ref
feat: added className for wrapper
docs: added describe summary and Quick Features
feat: added userAgentIntegration
Description
Checklist